Prefer routing to primary in a transaction. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 `route_pipeline` functions in the file, so we change one to avoid confusion.
barshaul
reviewed
Nov 12, 2023
redis/src/cluster_async/mod.rs
Outdated
| (None, _) => next_cmd_route, | ||
| (Some(route), None) => Some(route), | ||
| (Some(chosen_route), Some(next_cmd_route)) => { | ||
| if chosen_route.slot() == next_cmd_route.slot() |
There was a problem hiding this comment.
If we're iterating through all commands to check their routing, I think we should raise cross slot exception when we can catch it in the client side
barshaul
approved these changes
Nov 13, 2023
shachlanAmazon
merged commit 5c7e586
into
amazon-contributing:main
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will cause transactions with commands that are routed to replicas and primaries to prefer the primary routing over the replica.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.