Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Value::Map to aggregate cluster responses. #70

Closed
wants to merge 1 commit into from

Conversation

nihohit
Copy link

@nihohit nihohit commented Dec 10, 2023

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

result.map(|val| {
Value::Array(vec![Value::BulkString(addr.as_bytes().to_vec()), val])
})
result.map(|val| (Value::BulkString(addr.as_bytes().to_vec()), val))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using SimpleString for the address?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to change from the previous implementation. You prefer that?

@@ -1474,16 +1479,16 @@ fn test_cluster_fan_out_and_return_map_of_results_for_special_response_policy()

// TODO once RESP3 is in, return this as a map

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@nihohit nihohit closed this Dec 10, 2023
@nihohit nihohit deleted the use-map branch December 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants