Report missing slots in multi-slot request. #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihohit
force-pushed
the
missing-slots
branch
2 times, most recently
from
e6ee70d to
51ebf7d
Compare
nihohit
force-pushed
the
missing-slots
branch
from
51ebf7d to
085663a
Compare
barshaul
reviewed
Jan 1, 2024
| }), | ||
| ) | ||
| } else { | ||
| let _ = sender.send(Err(( |
There was a problem hiding this comment.
If I understand it right, if we have one cmd that we can't find the connection for it, all of the multi-command will be failed. right?
If so, why do we need to continue mapping after we send the error?
There was a problem hiding this comment.
This function doesn't take the response_policy into account, in order to remain simple. You're right that for some response policies we could fail immediately, but that would require more code complexity, and it would mean that if a function has side effects (SCRIPT LOAD, for example), no node will be affected - it would be equivalent to all nodes failing.
barshaul
reviewed
Jan 1, 2024
barshaul
approved these changes
Jan 1, 2024
shachlanAmazon
merged commit d7dc403
into
amazon-contributing:main
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
valkey-io/valkey-glide#705
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.