Formatted timestamps in the transcript should link! #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
force-pushed
the
transcript-timestamp-linking
branch
from
0c18057 to
7579cbf
Compare
hzoo
commented
Aug 2, 2019
| let hasTimestamp = false; | ||
| const children = React.Children.toArray(props.children).map((child, i) => { | ||
| if (i === 0 && typeof child === "string") { | ||
| const timestamp = child.match(/^\[(\d\d):(\d\d)(?::(\d\d))?\]/); |
There was a problem hiding this comment.
Check all the p tags, only check the first child in each one (since we are checking for [00:00:00]
Regex: https://regexr.com/
Also did some simple stuff to compute the number of seconds from the timestamp..
hzoo
commented
Aug 2, 2019
| }); | ||
|
|
||
| return ( | ||
| <p id={hasTimestamp ? `playFrom=${hasTimestamp}` : ''}> |
There was a problem hiding this comment.
I guess if we want it to move to the correct paragraph we need an id?? It's covered by the player atm though so it would be nice to move the player to the bottom maybe?
There was a problem hiding this comment.
I like the way heavybit does it, where there's no jump, and the player sticks to the top on scroll https://www.heavybit.com/library/podcasts/jamstack-radio/ep-42-structuring-content-with-simen-svale-skogsrud-and-knut-melvaer-of-sanity-io/
hzoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
😱😱😱 Fixes hzoo/hopeinsource.com#5
Just me trying to get this working (although now I'm trying to test and noticing some weirdness like are the timestamps they put actually accurate..)
Also mobile view of the player (and now these links) aren't great!