CI/CD Infrastructure #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
varunchennamadhava
approved these changes
Dec 17, 2025
Closed
ElijahSwiftIBM
added a commit
that referenced
this pull request
Dec 23, 2025
* Initial Alpha (#19) * Feature/includeparameter (#14) * Add skeleton for inclusion list parameter Extend interface/skeleton for include_list * Input POinter Attempt to add input pointer parameter for control blocks * Definitions outside of if statements * Attempt to map the intended inclusion list * Try Virtual Function to keep Control Block in Explorer * No longer have get return * Attempt to add the meat of the function -Add methods and members to control blocks to get name of control block, specific control blocks within it, and all control blocks within it -add functions in control block explorer to parse inclusion "map" into actionable data name fix * Update psa.cpp Update psa.cpp * Update cvt.cpp * Update asvt.cpp * algorithm cleanup * better cleanup * Update control_block.cpp * Update main.cpp * Finish addressing merge issues and commit hooks -Minor code updates that were lost in merge commit -Bring new code up to standard for cppcheck -Format new code with clang-format * Update _cbxp.c * Streamline Control Block Explorer Class Update control_block_explorer.hpp * Massive refactor -Shave 2 step process down to one -Change serialized json inclusion map to use a vector of strings still split by "dot" operators * Error Handling Logic * BIG UPDATE PR COMMENTS -Switch pre-processing to one hash map function -use try/catch with custom errors rather than passing return codes everywhere -style and name changes -Enforce more rigid parm structure on entry -Fix some behavioral bugs and oversights in inclusion preprocessing -General streamlining and refactoring of functions, methods, classes, etc. * Another Big Refactor -PR comments (mostly style, but streamlining of error code as well) -Reworked base and derived classes to allow for includables to be defined to the base class and include_map to be defined to the base and derived classes * Update ascb.cpp * Update control_block.hpp * . * .. * ... * PR Comments -ASCB pointer deref in ASVT -Minor name changes -Remove double wildcard error -Add control_block_name_ private member and add initialization to constructor -move include_map_ to protected and remove private using statement * Update asvt.cpp * Update asvt.cpp * PR Comments Mostly renaming things streamlining some unnecessary text, parms and strings * Update control_block.cpp * Update main.cpp * Last round of PR comments string compare with == remove vestiges of old mechanisms for control block management name changes minor tweaks * Update cvt.cpp * Update cvt.cpp * Update cvt.cpp * Final comments Update control_block_explorer.cpp * comments * Last Comments * include changes * Last round of comments * debug * Unit testing (#17) * initial commit 1 * cleaned code before include test cases * wrote test cases, need to check with team now * added space after every function * added .value * shell script done * made changes proposed by leonard 1 * PR changes requested by team * added tests to check for ascb and asvt entries whether it be a string or dict * added tests to check for ascb and asvt entries whether it be a string or dict one more place * made minor tweaks * added updates provided by leonard * grouped failure test cases together * grouped error test cases together * removed extra lines * style changes * Feat/oss housekeeping2 (#18) * Set explicit C/C++ standard and cleanup README. Signed-off-by: Leonard Carcaramo <[email protected]> * Update contribution guidelines and functional tests. Signed-off-by: Leonard Carcaramo <[email protected]> * Cleanup contribution guidelines and debug debug mode. Signed-off-by: Leonard Carcaramo <[email protected]> * Cleanup. Signed-off-by: Leonard Carcaramo <[email protected]> * Cleanup. Signed-off-by: Leonard Carcaramo <[email protected]> * Fix sdist packaging and pyproject.toml metadata. Signed-off-by: Leonard Carcaramo <[email protected]> --------- Signed-off-by: Leonard Carcaramo <[email protected]> * Fix _C.pyi and removed unused import from cbxp.py. Signed-off-by: Leonard Carcaramo <[email protected]> --------- Signed-off-by: Leonard Carcaramo <[email protected]> Co-authored-by: Elijah Swift <[email protected]> Co-authored-by: Varun Chennamadhava <[email protected]> * test commit Signed-off-by: varunchennamadhava <[email protected]> * error 1 Signed-off-by: varunchennamadhava <[email protected]> * error 2 Signed-off-by: varunchennamadhava <[email protected]> * fixed error Signed-off-by: varunchennamadhava <[email protected]> * fixed error 1 Signed-off-by: varunchennamadhava <[email protected]> * assb include Signed-off-by: varunchennamadhava <[email protected]> * assb all fields draft 1 Signed-off-by: varunchennamadhava <[email protected]> * Changed assbjbini and assbjbns to getString() Signed-off-by: varunchennamadhava <[email protected]> * added test cases Signed-off-by: varunchennamadhava <[email protected]> * made linting formatting changes Signed-off-by: varunchennamadhava <[email protected]> * fixed an error with p_ascb_addr, made it const Signed-off-by: varunchennamadhava <[email protected]> * fixed error with ascbasid Signed-off-by: varunchennamadhava <[email protected]> * moved a function from private to public to private in control_block_field formatter and used that function to remove kruft Signed-off-by: varunchennamadhava <[email protected]> * format and cleaning out 1 test case Signed-off-by: varunchennamadhava <[email protected]> --------- Signed-off-by: Leonard Carcaramo <[email protected]> Signed-off-by: varunchennamadhava <[email protected]> Co-authored-by: Leonard Carcaramo <[email protected]> Co-authored-by: Elijah Swift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: fixes #4
💻 What does this address?
clang-format,cppcheck, andruffon every push and pull request.ruffstyle rules topyproject.toml.ruffformatting requirement to contribution guidelines.pre-commithook to format all Python code with Ruff.Jenkinsfileto automate the following on a z/OS Jenkins build agent.clang-format.cppcheck.📋 Is there a test case?
All CI/CD infrastructure has been tested, including the creation of test GitHub releases using Jenkins.