-
Notifications
You must be signed in to change notification settings - Fork 2
Rebase dev #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rebase dev #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added trailing newlines to changed files -Removed extraneous trailing newlines from one file
Use const for parameters and members where appropriate use static for member function where appropriate
-Fix const parms in logger -Adjust makefile for running on platform
-Update makefile to work with z-open make and cppcheck - mover variable definition to where it's only defined in a path where it is used - Change rc checking logic to remove redundancy
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
…tly. Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Alpha Cleanup
Release 1.0a1
ElijahSwiftIBM
approved these changes
Feb 20, 2025
Collaborator
ElijahSwiftIBM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: N/A
💻 What does this address?
devcurrent with main. I don't know how it got out of sync.📟 Implementation Details
N/A
📋 Is there a test case?
N/A