-
Notifications
You must be signed in to change notification settings - Fork 2
CI/CD & Open Source Housekeeping #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Intgerate into main
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Emma S. <[email protected]>
Signed-off-by: Emma S. <[email protected]>
Fix DCO thingy
…out python code Signed-off-by: Emma S. <[email protected]>
Configured Ruff for more aggressive linting and excluded folders with…
Merge Keyring/Certificate extract changes into main.
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
Signed-off-by: Leonard Carcaramo <[email protected]>
ElijahSwiftIBM
approved these changes
May 1, 2025
Collaborator
ElijahSwiftIBM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; really streamlines things!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue Reference
Issue: fixes #3 #8
💻 What does this address?
clang-format(for C/C++ linting)cppcheck(for static code analysis)fuzz(using LibFuzzer, which is part of LLVM)ruff(for Python linting)test(for unit testing)Jenkinsfileto runcppcheck, unit tests, and publish the Python distributions of RACFu as GitHub releases (Publishing to PyPi will still need to be manual).Jenkinsfilealso handles getting the correct versions of OpenSSL and ZOSLIB from zopen community since they are now build dependencies required for certificate management.Makefilehas been updated to set up explicit compatibility for Linux and Mac (there are some differences) for the purposes of running unit test and other development tasks.make fuzz.clang-formatto lint C/C++ linting can be run usingmake lintrufflinting rules have been provided by @EmmasBox.ruffcomplaints.racfu(). Assuming that the request JSON provided is null terminated string can lead to buffer overflow issues.racfu()in theracfu_result_tstruct. The caller should not automatically assume that the result JSON is a null terminated string. RACFu now provides the length explicitly, which is more robust.new. The reason for this is because if there is a mismatch between what is used to allocate and free memory, this results in undefined behavior. Now, memory that gets preserved for the caller is allocated usingnewand is freed later usingdeleteto avoid undefined behavior.mutexinpython/_racfu.cto make the Python distribution of RACFu thread safe. Technically, the GIL prevents true multi-threading in Python, but this has been added to be safe.📋 Is there a test case?
See GitHub Actions workflows.
A Python wheel was also built and test installed to ensure everything works.