e_smi: fix const correctness for string literal arrays#31
Open
sivapt12 wants to merge 1 commit intoamd:masterfrom
Open
e_smi: fix const correctness for string literal arrays#31sivapt12 wants to merge 1 commit intoamd:masterfrom
sivapt12 wants to merge 1 commit intoamd:masterfrom
Conversation
String literals in C are of type `const char *`, but the arrays `freqlimitsrcnames` and `svi3_rail_index_names` were declared as `char * const`, which implies mutable data. This results in compiler warnings: warning: initialization discards ‘const’ qualifier Update both arrays to `const char * const` to correctly reflect that: - the string data is immutable - the array pointers are not reassigned This fixes -Wdiscarded-qualifiers warnings and improves const-correctness. Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
Contributor
|
Hi Siva, looks good for me, I will test once and then will Merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String literals in C are of type
const char *, but the arraysfreqlimitsrcnamesandsvi3_rail_index_nameswere declared aschar * const, which implies mutable data. This results in compiler warnings:warning: initialization discards ‘const’ qualifier
Update both arrays to
const char * constto correctly reflect that:This fixes -Wdiscarded-qualifiers warnings and improves const-correctness.