-
Notifications
You must be signed in to change notification settings - Fork 0
Support osqp 1.0.0 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The Windows build are failing due to osqp/osqp#744 . |
|
osqp-matlab doesn't have a 1.0 tag because it hasn't been fully updated to support the 1.0 release yet. It still is actually missing some new fields we added in the various structs to support the duality gap criteria, so you won't be able to use the develop-1.0 branch there until I update it (and Mathworks was down for a while recently, so I hadn't been able to open my MATLAB instance). |
Thanks for chiming in! Interestingly, the test seems to pass with the latest |
|
Windows failures will be solved by conda-forge/libosqp-feedstock#17 . |
It won't catastrophically fail anymore (we made the v1 MATLAB interface more resilient to changes in the solver structs, so it can still at least do basic things if they change), but you won't see any of the new solver info or be able to modify the duality gap settings until it gets updated. |
Clear, thanks! |
Add support to build against osqp 1.0.0 . As osqp-matlab 1.0.0 was not tagged, we build on top of the latest commit of the
develop-1.0branch, see osqp/osqp-matlab#55 . Furthermore, we also use the fix osqp/osqp-matlab#61 .