feat: getProjectList, insertProjectItem api 추가 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getProjectList: 메인홈에서 프로젝트 목록을 불러옵니다. insertProjectItem: 등록 페이지에서 프로젝트를 등록합니다.
getProjectList: 메인홈에서 프로젝트 목록을 불러옵니다. insertProjectItem: 등록 페이지에서 프로젝트를 등록합니다.
tkyoun0421
approved these changes
Jun 24, 2025
Comment on lines
8
to
23
| export async function getProjectList(): Promise<ProjectListRes[]> { | ||
| try { | ||
| const listRef = collection(db, "projects"); | ||
| const querySnapshot = await getDocs(listRef); | ||
|
|
||
| const posts = querySnapshot.docs.map((doc) => ({ | ||
| id: doc.id, | ||
| ...doc.data(), | ||
| })); | ||
|
|
||
| return posts as ProjectListRes[]; | ||
| } catch (err) { | ||
| console.log(err); | ||
| return []; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
요고 컨벤션에 맞게 export const getProjectList = async() => {};
방식으로 부탁드리겠습니다 🙇
Comment on lines
8
to
27
| export async function insertProjectItem( | ||
| projectItem: ProjectItemInsertReq | ||
| ): Promise<{ success: boolean; message: string; id?: string }> { | ||
| try { | ||
| const postsRef = collection(db, "projects"); | ||
| const docRef = await addDoc(postsRef, projectItem); | ||
|
|
||
| return { | ||
| success: true, | ||
| message: "프로젝트가 성공적으로 등록되었습니다.", | ||
| id: docRef.id, | ||
| }; | ||
| } catch (err) { | ||
| console.log(err); | ||
| return { | ||
| success: false, | ||
| message: "프로젝트 등록에 실패하였습니다.", | ||
| }; | ||
| } | ||
| } |
Comment on lines
+9
to
+14
| if (res.success) { | ||
| alert(res.message); | ||
| } else { | ||
| alert(res.message); | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
성공하거나 안하거나 같은 로직인걸로 보이는데 혹시 어떤 이유가 있으실까요??
Contributor
Author
There was a problem hiding this comment.
저는 이 훅에 대해 더이상 건들지 않고 민영님께 인계 할 생각이었으므로
이후에 성공 실패에 따라 다른 처리가 들어갈 수 도 있으니 그저 가시성을 위해 나눠놓았습니다.
Contributor
|
수고하셨어용 !! |
tkyoun0421
merged commit 80a17c1
into
amicable-development-center:develop
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
firebase의 projects 데이터를 조회, 저장 함수를 간단하게 추가하였습니다.
변경 사항
구현 내용
개발 후기 및 개선사항
이번 작업에서 배운 점
어려웠던 점 / 에로사항
다음에 개선하고 싶은 점
팀원들과 공유하고 싶은 팁