refactor: 프로젝트 삭제 로직 useDeleteProjectsMutation 훅으로 통합 및 리팩토링 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyoun0421
approved these changes
Jun 28, 2025
Comment on lines
+146
to
+151
| // 문서 ID를 직접 생성하여 삭제 (더 효율적) | ||
| const deletePromises = projectIds.map((projectId) => { | ||
| const likeId = `${userId}_${projectId}`; | ||
| return deleteDoc(doc(db, "likes", likeId)); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
오호.. 랜덤 ID가 아닌 부분이 이런 장점이 있었네여
firebase 또 쓸 일이 있다면 써먹을 수 있을 것 같네요 배워갑니다 💯
Comment on lines
+103
to
+115
| const invalidateLikeQueries = async (): Promise<void> => { | ||
| const queries = [ | ||
| [queryKeys.myLikedProjects, "details"], | ||
| [queryKeys.myLikedProjects, "ids"], | ||
| [queryKeys.projectLike], | ||
| [queryKeys.projectLikedUser], | ||
| [queryKeys.projects], // 홈페이지, 프로젝트 찾기 페이지 동기화 | ||
| ]; | ||
|
|
||
| await Promise.all( | ||
| queries.map((queryKey) => queryClient.invalidateQueries({ queryKey })) | ||
| ); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
호오 그러쿤욥 ! 사실 이 부분이 이전에 동기처리로 되어있었는데 너무 복잡해보여서 바꿨습니당..ㅎㅎ
Comment on lines
+71
to
+82
| useEffect(() => { | ||
| if (appliedProjectsData) { | ||
| setAppliedProjects(appliedProjectsData); | ||
| } | ||
| }, [appliedProjectsData, setAppliedProjects]); | ||
|
|
||
| // 좋아요한 프로젝트 데이터를 store에 동기화 | ||
| useEffect(() => { | ||
| if (myLikedProjectsData) { | ||
| setLikeProjects(myLikedProjectsData); | ||
| } | ||
| }, [myLikedProjectsData, setLikeProjects]); |
Contributor
There was a problem hiding this comment.
요게 어떤 로직인지 궁금합니다! 데이터를 받아오면 store에 동기화 하는 코드일까여?
Contributor
Author
There was a problem hiding this comment.
넵 지원한프로젝트랑 좋아요한프로젝트를 스토어에 동기화하는 코드에욥 !
Contributor
There was a problem hiding this comment.
그렇군여! 그럼 쿼리에서 관리하지 않으신가요??!
Contributor
Author
There was a problem hiding this comment.
쿼리에서 관리하고 있고, store는 전역 상태 동기화/빠른 접근을 위해 추가로 사용하는 보조 수단이에요!
tkyoun0421
merged commit 9244cfa
into
amicable-development-center:develop
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
좋아요 삭제 후 상세페이지에선 좋아요가 남아있는 이슈
변경 사항
구현 내용
개발 후기 및 개선사항
이번 작업에서 배운 점
어려웠던 점 / 에로사항
다음에 개선하고 싶은 점
팀원들과 공유하고 싶은 팁