Make update.sh work with RHEL-based distros#2046
Open
egg82 wants to merge 5 commits intoamidaware:developfrom
Open
Make update.sh work with RHEL-based distros#2046egg82 wants to merge 5 commits intoamidaware:developfrom
egg82 wants to merge 5 commits intoamidaware:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following changes are made:
/etc/os-releaseto determine OS typecommand -v dnfto determine ifdnfis available, and falls back toyumif notyum/dnfin place ofaptandapt-getwhere applicablewww-datafornginxuser/group where applicablepangoandpango-develfrom proper sources when in a RHEL environmentpyenvto install proper python version when in RHEL environmentdnf/yuminstall when in a RHEL environmentpython manage.pytopython3.11 manage.pyto be consistent/etc/nginx/sites-availableto/etc/nginx/conf.dwhen in a RHEL environment/rmm/api/tacticalrmm/tacticalrmm.sock(nginx can't access socket)The biggest change is the use of
pyenvwhich required editing the service files, but it works well. This change could easily be added to the Debian section if desired, which would be less work than manually compiling the version each time.