feat: Add a sync implementation #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amodm
requested changes
Aug 6, 2025
Owner
amodm
left a comment
amodm
left a comment
There was a problem hiding this comment.
Thanks @pchaseh. This looks like a clean way of getting this done, so I appreciate you saving me a ton of time here.
Would you be able to replicate the existing tests for SyncConnection too? If not, I'll merge this PR anyway, and take up the test addition in the next few days as I get time.
Owner
|
Thanks for your contribution @pchaseh. I modified the tests to account for the sync connection too. A small note for future contributions, if any - please sign your commits, it's easy and a good practice. |
Owner
|
FYI, this is now released as v0.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sync implementation of the
Connectiontype,SyncConnection. This is accomplished by moving all message parsing logic out ofConnectionto be reused by both implementations, and then duplicating the minimum required functions toSyncConnection. This is what I've found to be the cleanest path forward, but I'm open to other ideas.There's also some linting errors that have been fixed with clippy via version 0.1.88, if preferred I can move those into a separate pull request
Closes #2