test: add createInstallation e2e test with proper connection data handling#78
Open
dionlow wants to merge 1 commit into
Open
test: add createInstallation e2e test with proper connection data handling#78dionlow wants to merge 1 commit into
dionlow wants to merge 1 commit into
Conversation
…dling Add comprehensive end-to-end test for createInstallation tool that: - Checks for existing Salesforce connection and retrieves its data - Uses connection's groupRef to avoid group mismatch errors - Detects and skips creation if installation already exists - Validates installation creation with proper assertions Also includes code improvements: - Refactor installation helper to extract requestBody for better debugging - Add proper TypeScript typing for ListInstallationsInstallation - Clean up connection helper with better type checking 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
caiopizzol
reviewed
Jan 24, 2026
| @@ -1,4 +1,5 @@ | |||
| import { SDKNodePlatform } from '@amp-labs/sdk-node-platform'; | |||
| import { ListInstallationsInstallation } from '@amp-labs/sdk-node-platform/src/models/operations/listinstallations'; | |||
Collaborator
There was a problem hiding this comment.
this import path uses src/ which I think won't exist in the published package.
either import from models/operations/listinstallations or re-export these types from the main entry point at the SDK
|
|
||
| const toolResult = toolResults[0].result; | ||
| assert('created' in toolResult, 'Result should have "created" field'); | ||
| assert( |
Collaborator
There was a problem hiding this comment.
shouldn't we assert toolResult.created === true? looks likeit passes even if the installation failed to create
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR stacks on top of #dl-modular-e2e-tests