Skip to content

[ENG-3834] feat: support microsoft admin consent #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RajatPawar wants to merge 4 commits into
base: main
Choose a base branch
from
+158 −148
Open

[ENG-3834] feat: support microsoft admin consent #2931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6a206e
ms admin consent
RajatPawar Apr 27, 2026
86731c7
new url
RajatPawar Apr 27, 2026
1da6318
add metadata
RajatPawar Apr 28, 2026
51d3fd8
make lint
RajatPawar Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
268 changes: 134 additions & 134 deletions connector/new.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,138 +148,138 @@ func New(provider providers.Provider, params common.ConnectorParams) (connectors
}

var connectorConstructors = map[providers.Provider]outputConstructorFunc{ // nolint:gochecknoglobals
providers.AWS: wrapper(newAWSConnector),
providers.AcuityScheduling: wrapper(newAcuitySchedulingConnector),
providers.Aha: wrapper(newAhaConnector),
providers.Aircall: wrapper(newAircallConnector),
providers.Amplitude: wrapper(newAmplitudeConnector),
providers.Apollo: wrapper(newApolloConnector),
providers.Asana: wrapper(newAsanaConnector),
providers.Ashby: wrapper(newAshbyConnector),
providers.Atlassian: wrapper(newAtlassianConnector),
providers.Attio: wrapper(newAttioConnector),
providers.Avoma: wrapper(newAvomaConnector),
providers.BigQuery: wrapper(newBigQueryConnector),
providers.Bentley: wrapper(newBentleyConnector),
providers.Bitbucket: wrapper(newBitBucketConnector),
providers.Blackbaud: wrapper(newBlackbaudConnector),
providers.Blueshift: wrapper(newBlueshiftConnector),
providers.Braintree: wrapper(newBraintreeConnector),
providers.Braze: wrapper(newBrazeConnector),
providers.Breakcold: wrapper(newBreakcoldConnector),
providers.Brevo: wrapper(newBrevoConnector),
providers.Calendly: wrapper(newCalendlyConnector),
providers.CallRail: wrapper(newCallRail),
providers.CampaignMonitor: wrapper(newCampaignMonitorConnector),
providers.Capsule: wrapper(newCapsuleConnector),
providers.Chargebee: wrapper(newChargebeeConnector),
providers.ChargeOver: wrapper(newChargeOver),
providers.ChiliPiper: wrapper(newChiliPiperConnector),
providers.Chorus: wrapper(newChorusConnector),
providers.ClariCopilot: wrapper(newClariCopilotConnector),
providers.ClickUp: wrapper(newClickUpConnector),
providers.Close: wrapper(newCloseConnector),
providers.CloudTalk: wrapper(newCloudTalkConnector),
providers.ConstantContact: wrapper(newConstantContactConnector),
providers.Copper: wrapper(newCopperConnector),
providers.CustomerJourneysApp: wrapper(newCustomerJourneysAppConnector),
providers.DevRev: wrapper(newDevRevConnector),
providers.Dixa: wrapper(newDixaConnector),
providers.Docusign: wrapper(newDocusignConnector),
providers.Drift: wrapper(newDriftConnector),
providers.DropboxSign: wrapper(newDropboxSignConnector),
providers.DynamicsBusinessCentral: wrapper(newDynamicsBusinessCentral),
providers.DynamicsCRM: wrapper(newDynamicsCRMConnector),
providers.FastSpring: wrapper(newFastSpringConnector),
providers.Fathom: wrapper(newFathomConnector),
providers.Fireflies: wrapper(newFirefliesConnector),
providers.Flatfile: wrapper(newFlatfileConnector),
providers.FourFour: wrapper(newFourFourConnector),
providers.Freshdesk: wrapper(newFreshdeskConnector),
providers.Front: wrapper(newFrontConnector),
providers.G2: wrapper(newG2Connector),
providers.GetResponse: wrapper(newGetResponseConnector),
providers.GitLab: wrapper(newGitLabConnector),
providers.Github: wrapper(newGithubConnector),
providers.Gong: wrapper(newGongConnector),
providers.Google: wrapper(newGoogleConnector),
providers.GoogleWorkspaceDelegation: wrapper(newGoogleWorkspaceDelegationConnector),
providers.Gorgias: wrapper(newGorgiasConnector),
providers.Granola: wrapper(newGranolaConnector),
providers.Groove: wrapper(newGrooveConnector),
providers.HappyFox: wrapper(newHappyFoxConnector),
providers.HelpScoutMailbox: wrapper(newHelpScoutMailboxConnector),
providers.HeyReach: wrapper(newHeyReachConnector),
providers.HousecallPro: wrapper(newHousecallProConnector),
providers.HighLevelStandard: wrapper(newHighLevelStandardConnector),
providers.HighLevelWhiteLabel: wrapper(newHighLevelWhiteLabelConnector),
providers.Hubspot: wrapper(newHubspotConnector),
providers.Hunter: wrapper(newHunterConnector),
providers.Insightly: wrapper(newInsightlyConnector),
providers.Instantly: wrapper(newInstantlyConnector),
providers.InstantlyAI: wrapper(newInstantlyAIConnector),
providers.Intercom: wrapper(newIntercomConnector),
providers.Iterable: wrapper(newIterableConnector),
providers.Jobber: wrapper(newJobberConnector),
providers.JustCall: wrapper(newJustCallConnector),
providers.KaseyaVSAX: wrapper(newKaseyaVSAXConnector),
providers.Keap: wrapper(newKeapConnector),
providers.Kit: wrapper(newKitConnector),
providers.Klaviyo: wrapper(newKlaviyoConnector),
providers.Lemlist: wrapper(newLemlistConnector),
providers.Lever: wrapper(newLeverConnector),
providers.Linear: wrapper(newLinearConnector),
providers.LinkedIn: wrapper(newLinkedInConnector),
providers.Loxo: wrapper(newLoxoConnector),
providers.Marketo: wrapper(newMarketoConnector),
providers.Microsoft: wrapper(newMicrosoftConnector),
providers.MicrosoftClientCredentials: wrapper(newMicrosoftClientCredentialsConnector),
providers.Mixmax: wrapper(newMixmaxConnector),
providers.Monday: wrapper(newMondayConnector),
providers.Netsuite: wrapper(newNetsuiteConnector),
providers.NetsuiteM2M: wrapper(newNetsuiteM2MConnector),
providers.Nutshell: wrapper(newNutshellConnector),
providers.Okta: wrapper(newOktaConnector),
providers.Outplay: wrapper(newOutplayConnector),
providers.Outreach: wrapper(newOutreachConnector),
providers.Paddle: wrapper(newPaddleConnector),
providers.PhoneBurner: wrapper(newPhoneBurnerConnector),
providers.Pinterest: wrapper(newPinterestConnector),
providers.Pipedrive: wrapper(newPipedriveConnector),
providers.Pipeliner: wrapper(newPipelinerConnector),
providers.Podium: wrapper(newPodiumConnector),
providers.Pylon: wrapper(newPylonConnector),
providers.QuickBooks: wrapper(newQuickbooksConnector),
providers.QuickbooksSandbox: wrapper(newQuickbooksSandboxConnector),
providers.Recurly: wrapper(newRecurlyConnector),
providers.RevenueCat: wrapper(newRevenueCatConnector),
providers.RingCentral: wrapper(newRingCentral),
providers.SageIntacct: wrapper(newSageIntacctConnector),
providers.Salesfinity: wrapper(newSalesfinityConnector),
providers.Salesflare: wrapper(newSalesflareConnector),
providers.Salesforce: wrapper(newSalesforceConnector),
providers.SalesforceJWT: wrapper(newSalesforceJWTConnector),
providers.Salesloft: wrapper(newSalesloftConnector),
providers.Seismic: wrapper(newSeismicConnector),
providers.Sellsy: wrapper(newSellsyConnector),
providers.ServiceNow: wrapper(newServiceNowConnector),
providers.Shopify: wrapper(newShopifyConnector),
providers.Slack: wrapper(newSlackConnector),
providers.Smartlead: wrapper(newSmartleadConnector),
providers.SnapchatAds: wrapper(newSnapchatAdsConnector),
providers.Snowflake: wrapper(newSnowflakeConnector),
providers.SolarWindsServiceDesk: wrapper(newSolarWindsConnector),
providers.Stripe: wrapper(newStripeConnector),
providers.SuperSend: wrapper(newSuperSendConnector),
providers.Talkdesk: wrapper(newTalkdeskConnector),
providers.Teamleader: wrapper(newTeamleaderConnector),
providers.Teamwork: wrapper(newTeamworkConnector),
providers.Webex: wrapper(newWebexConnector),
providers.Xero: wrapper(newXeroConnector),
providers.ZendeskChat: wrapper(newZendeskChatConnector),
providers.ZendeskSupport: wrapper(newZendeskSupportConnector),
providers.Zoho: wrapper(newZohoConnector),
providers.Zoom: wrapper(newZoomConnector),
providers.AWS: wrapper(newAWSConnector),
providers.AcuityScheduling: wrapper(newAcuitySchedulingConnector),
providers.Aha: wrapper(newAhaConnector),
providers.Aircall: wrapper(newAircallConnector),
providers.Amplitude: wrapper(newAmplitudeConnector),
providers.Apollo: wrapper(newApolloConnector),
providers.Asana: wrapper(newAsanaConnector),
providers.Ashby: wrapper(newAshbyConnector),
providers.Atlassian: wrapper(newAtlassianConnector),
providers.Attio: wrapper(newAttioConnector),
providers.Avoma: wrapper(newAvomaConnector),
providers.BigQuery: wrapper(newBigQueryConnector),
providers.Bentley: wrapper(newBentleyConnector),
providers.Bitbucket: wrapper(newBitBucketConnector),
providers.Blackbaud: wrapper(newBlackbaudConnector),
providers.Blueshift: wrapper(newBlueshiftConnector),
providers.Braintree: wrapper(newBraintreeConnector),
providers.Braze: wrapper(newBrazeConnector),
providers.Breakcold: wrapper(newBreakcoldConnector),
providers.Brevo: wrapper(newBrevoConnector),
providers.Calendly: wrapper(newCalendlyConnector),
providers.CallRail: wrapper(newCallRail),
providers.CampaignMonitor: wrapper(newCampaignMonitorConnector),
providers.Capsule: wrapper(newCapsuleConnector),
providers.Chargebee: wrapper(newChargebeeConnector),
providers.ChargeOver: wrapper(newChargeOver),
providers.ChiliPiper: wrapper(newChiliPiperConnector),
providers.Chorus: wrapper(newChorusConnector),
providers.ClariCopilot: wrapper(newClariCopilotConnector),
providers.ClickUp: wrapper(newClickUpConnector),
providers.Close: wrapper(newCloseConnector),
providers.CloudTalk: wrapper(newCloudTalkConnector),
providers.ConstantContact: wrapper(newConstantContactConnector),
providers.Copper: wrapper(newCopperConnector),
providers.CustomerJourneysApp: wrapper(newCustomerJourneysAppConnector),
providers.DevRev: wrapper(newDevRevConnector),
providers.Dixa: wrapper(newDixaConnector),
providers.Docusign: wrapper(newDocusignConnector),
providers.Drift: wrapper(newDriftConnector),
providers.DropboxSign: wrapper(newDropboxSignConnector),
providers.DynamicsBusinessCentral: wrapper(newDynamicsBusinessCentral),
providers.DynamicsCRM: wrapper(newDynamicsCRMConnector),
providers.FastSpring: wrapper(newFastSpringConnector),
providers.Fathom: wrapper(newFathomConnector),
providers.Fireflies: wrapper(newFirefliesConnector),
providers.Flatfile: wrapper(newFlatfileConnector),
providers.FourFour: wrapper(newFourFourConnector),
providers.Freshdesk: wrapper(newFreshdeskConnector),
providers.Front: wrapper(newFrontConnector),
providers.G2: wrapper(newG2Connector),
providers.GetResponse: wrapper(newGetResponseConnector),
providers.GitLab: wrapper(newGitLabConnector),
providers.Github: wrapper(newGithubConnector),
providers.Gong: wrapper(newGongConnector),
providers.Google: wrapper(newGoogleConnector),
providers.GoogleWorkspaceDelegation: wrapper(newGoogleWorkspaceDelegationConnector),
providers.Gorgias: wrapper(newGorgiasConnector),
providers.Granola: wrapper(newGranolaConnector),
providers.Groove: wrapper(newGrooveConnector),
providers.HappyFox: wrapper(newHappyFoxConnector),
providers.HelpScoutMailbox: wrapper(newHelpScoutMailboxConnector),
providers.HeyReach: wrapper(newHeyReachConnector),
providers.HousecallPro: wrapper(newHousecallProConnector),
providers.HighLevelStandard: wrapper(newHighLevelStandardConnector),
providers.HighLevelWhiteLabel: wrapper(newHighLevelWhiteLabelConnector),
providers.Hubspot: wrapper(newHubspotConnector),
providers.Hunter: wrapper(newHunterConnector),
providers.Insightly: wrapper(newInsightlyConnector),
providers.Instantly: wrapper(newInstantlyConnector),
providers.InstantlyAI: wrapper(newInstantlyAIConnector),
providers.Intercom: wrapper(newIntercomConnector),
providers.Iterable: wrapper(newIterableConnector),
providers.Jobber: wrapper(newJobberConnector),
providers.JustCall: wrapper(newJustCallConnector),
providers.KaseyaVSAX: wrapper(newKaseyaVSAXConnector),
providers.Keap: wrapper(newKeapConnector),
providers.Kit: wrapper(newKitConnector),
providers.Klaviyo: wrapper(newKlaviyoConnector),
providers.Lemlist: wrapper(newLemlistConnector),
providers.Lever: wrapper(newLeverConnector),
providers.Linear: wrapper(newLinearConnector),
providers.LinkedIn: wrapper(newLinkedInConnector),
providers.Loxo: wrapper(newLoxoConnector),
providers.Marketo: wrapper(newMarketoConnector),
providers.Microsoft: wrapper(newMicrosoftConnector),
providers.MicrosoftAdminConsent: wrapper(newMicrosoftAdminConsentConnector),
providers.Mixmax: wrapper(newMixmaxConnector),
providers.Monday: wrapper(newMondayConnector),
providers.Netsuite: wrapper(newNetsuiteConnector),
providers.NetsuiteM2M: wrapper(newNetsuiteM2MConnector),
providers.Nutshell: wrapper(newNutshellConnector),
providers.Okta: wrapper(newOktaConnector),
providers.Outplay: wrapper(newOutplayConnector),
providers.Outreach: wrapper(newOutreachConnector),
providers.Paddle: wrapper(newPaddleConnector),
providers.PhoneBurner: wrapper(newPhoneBurnerConnector),
providers.Pinterest: wrapper(newPinterestConnector),
providers.Pipedrive: wrapper(newPipedriveConnector),
providers.Pipeliner: wrapper(newPipelinerConnector),
providers.Podium: wrapper(newPodiumConnector),
providers.Pylon: wrapper(newPylonConnector),
providers.QuickBooks: wrapper(newQuickbooksConnector),
providers.QuickbooksSandbox: wrapper(newQuickbooksSandboxConnector),
providers.Recurly: wrapper(newRecurlyConnector),
providers.RevenueCat: wrapper(newRevenueCatConnector),
providers.RingCentral: wrapper(newRingCentral),
providers.SageIntacct: wrapper(newSageIntacctConnector),
providers.Salesfinity: wrapper(newSalesfinityConnector),
providers.Salesflare: wrapper(newSalesflareConnector),
providers.Salesforce: wrapper(newSalesforceConnector),
providers.SalesforceJWT: wrapper(newSalesforceJWTConnector),
providers.Salesloft: wrapper(newSalesloftConnector),
providers.Seismic: wrapper(newSeismicConnector),
providers.Sellsy: wrapper(newSellsyConnector),
providers.ServiceNow: wrapper(newServiceNowConnector),
providers.Shopify: wrapper(newShopifyConnector),
providers.Slack: wrapper(newSlackConnector),
providers.Smartlead: wrapper(newSmartleadConnector),
providers.SnapchatAds: wrapper(newSnapchatAdsConnector),
providers.Snowflake: wrapper(newSnowflakeConnector),
providers.SolarWindsServiceDesk: wrapper(newSolarWindsConnector),
providers.Stripe: wrapper(newStripeConnector),
providers.SuperSend: wrapper(newSuperSendConnector),
providers.Talkdesk: wrapper(newTalkdeskConnector),
providers.Teamleader: wrapper(newTeamleaderConnector),
providers.Teamwork: wrapper(newTeamworkConnector),
providers.Webex: wrapper(newWebexConnector),
providers.Xero: wrapper(newXeroConnector),
providers.ZendeskChat: wrapper(newZendeskChatConnector),
providers.ZendeskSupport: wrapper(newZendeskSupportConnector),
providers.Zoho: wrapper(newZohoConnector),
providers.Zoom: wrapper(newZoomConnector),
}

type outputConstructorFunc func(p common.ConnectorParams) (connectors.Connector, error)
Expand Down Expand Up @@ -432,10 +432,10 @@ func newMicrosoftConnector(
return microsoft.NewConnector(params)
}

func newMicrosoftClientCredentialsConnector(
func newMicrosoftAdminConsentConnector(
params common.ConnectorParams,
) (*microsoft.Connector, error) {
return microsoft.NewConnectorForProvider(providers.MicrosoftClientCredentials, params)
return microsoft.NewConnectorForProvider(providers.MicrosoftAdminConsent, params)
}

func newInstantlyConnector(
Expand Down
2 changes: 1 addition & 1 deletion providers/google/records_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ func TestMailGetRecordsByIds(t *testing.T) { //nolint:funlen
ids: []string{idOK1, idMissing},
server: func() *mockserver.Switch {
return &mockserver.Switch{
Setup: mockserver.ContentJSON(),
Setup: mockserver.ContentJSON(),
Default: mockserver.Response(http.StatusNotFound, errorNotFound),
}
},
Expand Down
Loading
Loading