tidy(testutils): Relocate CompareResult#2944
Merged
Merged
Conversation
This was referenced May 1, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 1, 2026
Contributor
Author
|
@AmandaYao00 there are some improvements -- tidying of the |
d8d8483 to
814b593
Compare
AmandaYao00
approved these changes
May 4, 2026
814b593 to
735cffd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR refines and generalizes the recently introduced
CompareResult.Key changes
Package relocation
The
CompareResulttype has been moved frommockutilstotestutils.While
mockutilsis intended for provider-specific mocking utilities,CompareResultis a more general-purpose testing construct.Improved
AddDiffAPICompareResult.AddDiffpreviously required preformatted messages (commonly viafmt.Sprintf).It now accepts a format string with variadic arguments, simplifying usage and reducing boilerplate.
Renamed assertion methods
The main methods are now named
AssertandAssertErr.Their return semantics have been updated to align with common testing conventions:
trueindicates successfalseindicates failureThis replaces the previous, less intuitive behavior where
trueindicated an error.Centralized validation logic
Validation is now fully owned by
CompareResult, from instantiation through theValidatestage.Calling
Validatewill invoket.Fatal(...)if any assertions have failed, making failure handling explicit and easier to follow.