Skip to content

[ENG-3815] feat(microsoft): Impl Subscription Maintainer #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cobalt0s wants to merge 1 commit into
base: cobalt0s/microsoft-subscribe-update
Choose a base branch
from
Open

[ENG-3815] feat(microsoft): Impl Subscription Maintainer #2946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions providers/microsoft/internal/subscriber/maintenance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package subscriber

import (
"context"

"github.com/amp-labs/connectors/common"
)

// TODO testing? Types for interface?

Check failure on line 9 in providers/microsoft/internal/subscriber/maintenance.go

View workflow job for this annotation

GitHub Actions / lint 

godoc should start with symbol name ("RunScheduledMaintenance") (godoclint)

Check failure on line 9 in providers/microsoft/internal/subscriber/maintenance.go

View workflow job for this annotation

GitHub Actions / lint 

godoc should start with symbol name ("RunScheduledMaintenance") (godoclint)
func (s Strategy) RunScheduledMaintenance(
ctx context.Context,
params common.SubscribeParams,
previousResult *common.SubscriptionResult,
) (*common.SubscriptionResult, error) {
return s.UpdateSubscription(ctx, params, previousResult)
Copy link
Copy Markdown
Contributor Author

@Cobalt0s Cobalt0s May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that would be the whole implementation. The refresh will be executed for each object. If for some reason an object was removed and expired it will be recreated.

}
Loading