Skip to content

tidy(hubspot): Use only ProviderInfo.BaseURL and urlbuilder#2964

Merged
Cobalt0s merged 7 commits into
mainfrom
cobalt0s/hubspot-urls
May 8, 2026
Merged

tidy(hubspot): Use only ProviderInfo.BaseURL and urlbuilder#2964
Cobalt0s merged 7 commits into
mainfrom
cobalt0s/hubspot-urls

Conversation

@Cobalt0s
Copy link
Copy Markdown
Contributor

@Cobalt0s Cobalt0s commented May 7, 2026

Description

Update URL building. This was the last connector in the whole codebase to use string concats, manual query param building.

Changes

You may review changes by commits. They are small and speak for themselves.

Summary:

  • ModuleInfo() is fully replaced with ProviderInfo() + crm
  • Query params are handled by urlbuilder.URL.WithQueryParam out of the box.
  • Renamed URL methods and added docs to explain Objects vs Lists vs Misc endpoints.
    • This should help distinguish Objects (CRM Objects API) vs Lists (CRM but not Objects API) vs Marketing.
  • Strategies that use their own URL endpoints to achieve their unique goals are updated to ProviderInfo() + crm as well.

Live Tests

CRUD contacts:
image

Search Lists:
image

Get contacts by record ids:
image

Read Companies with contact associations:
image

Batch create contacts:
image

Batch update contacts with with associations:
image

Upsert Metadata
image

Read contacts via search with company association:
image

Copy link
Copy Markdown
Contributor Author

Cobalt0s commented May 7, 2026

@Cobalt0s Cobalt0s self-assigned this May 7, 2026
@Cobalt0s Cobalt0s marked this pull request as ready for review May 7, 2026 19:18
@Cobalt0s Cobalt0s requested a review from laurenzlong May 7, 2026 19:33
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-no-crm branch from 3489efe to 357a52f Compare May 7, 2026 19:45
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-urls branch from 9c0a603 to 399021a Compare May 7, 2026 19:45
Comment thread providers/hubspot/url_test.go
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-no-crm branch from 357a52f to 2a7f17a Compare May 8, 2026 17:25
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-urls branch from 399021a to 2467205 Compare May 8, 2026 17:25
Base automatically changed from cobalt0s/hubspot-no-crm to main May 8, 2026 17:35
@Cobalt0s Cobalt0s force-pushed the cobalt0s/hubspot-urls branch from 2467205 to f8996e6 Compare May 8, 2026 17:42
@Cobalt0s Cobalt0s merged commit 05e48b1 into main May 8, 2026
6 checks passed
@Cobalt0s Cobalt0s deleted the cobalt0s/hubspot-urls branch May 8, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants