Open
Conversation
The http gem added support for Ruby 2.7 with version 4.3.
jrmhaig
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Apr 15, 2021
This is using this branch on Github: https://github.com/jrmhaig/googlemaps-services/tree/update_http One it has been merged and a new version released then that should be used instead (see amrfaissal/googlemaps-services#13)
jrmhaig
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Apr 15, 2021
This is using this branch on Github: https://github.com/jrmhaig/googlemaps-services/tree/update_http One it has been merged and a new version released then that should be used instead (see amrfaissal/googlemaps-services#13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using this gem and have identified an intermittent fault after upgrading to Ruby 2.7. The
httpgem is pinned to version 3 but Ruby 2.7 support was added with version 4.3.0.I have a test to demonstrate:
At some point you get a
can't modify frozen String: "" (FrozenError)error athttp-3.3.0/lib/http/response/body.rb:52. This is resolved with version 4.3 or later ofhttp.