UCLchem interface #1070
Open
UCLchem interface #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
LourensVeen
added
keep-open
and removed
stale
rieder
requested changes
Jun 3, 2025
There was a problem hiding this comment.
Needs some work:
- remove unintended files/changes
- update to new build system
- download a specific version of UCLChem rather than adding a version to the AMUSE repository
- unittest for the uclchem interface
- preferably: an
amuse.community.interface.chemmodule that the interfaces for UCLChem and Krome inherit from
There was a problem hiding this comment.
Obsolete after recent update to AMUSE installation method
There was a problem hiding this comment.
needs updating to new build system
| .. [#] ADS:2017AJ....154...38H (Holdship, J. ; Viti, S, ; Jiménez-Serra, I.; Makrymallis, A. ; Priestley, F. , 2017, AJ) | ||
| """ | ||
|
|
||
| def __init__(self, mode="cpu", **options): |
There was a problem hiding this comment.
is there another mode than "cpu"?
| return n_out, param_dict, out_species | ||
|
|
||
|
|
||
| class UCLchem(CommonCode): |
There was a problem hiding this comment.
now that there are two chemistry codes, we should try to make amuse.community.interface.chem.ChemistryInterface.
| cm = named("centimeter", "cm", 0.01 * m) | ||
| erg = named("erg", "erg", 1e-7 * J) | ||
| barye = named("barye", "Ba", 0.1 * Pa) | ||
|
|
There was a problem hiding this comment.
reordering should not be done in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the chemical evolution code UCLchem as a community code. All the relevant changes are in the community/uclchem folder.