mux: adg2404: add initial driver support #2712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiclaus
requested review from
buha,
CiprianRegus,
dbogdan,
rbolboac and
danmois
as code owners
CiprianRegus
reviewed
Sep 1, 2025
drivers/mux/adg2404/adg2404.c
Outdated
Comment on lines
58
to
61
| ret = adg2404_enable(dev, ADG2404_DISABLE); | ||
| if (ret) | ||
| return ret; | ||
| return 0; |
drivers/mux/adg2404/adg2404.c
Outdated
Comment on lines
105
to
103
| dev = (struct adg2404_dev *)no_os_malloc(sizeof(*dev)); | ||
| if (!dev) | ||
| return -ENOMEM; |
drivers/mux/adg2404/adg2404.c
Outdated
| * @param state - ADG2404_ENABLE or ADG2404_DISABLE. | ||
| * @return 0 in case of success, negative error code otherwise. | ||
| */ | ||
| int adg2404_enable(struct adg2404_dev *dev, enum adg2404_state state) |
There was a problem hiding this comment.
If the state is just enable/disable, you can use bool for the state's type
buha
reviewed
Sep 1, 2025
drivers/mux/adg2404/adg2404.h
Outdated
| struct no_os_gpio_desc *gpio_a0; | ||
| struct no_os_gpio_desc *gpio_a1; | ||
| struct no_os_gpio_desc *gpio_en; | ||
| enum adg2404_type device_type; |
There was a problem hiding this comment.
this is stored in adg2404_dev but not used anywhere, so i think it can be dropped
drivers/mux/adg2404/adg2404.c
Outdated
| if (!dev) | ||
| return -EINVAL; | ||
|
|
||
| return no_os_gpio_set_value(dev->gpio_en, state); |
There was a problem hiding this comment.
i think a warning is generated here for casting, maybe try explicit cast ?
CiprianRegus
reviewed
Sep 1, 2025
drivers/mux/adg2404/adg2404.c
Outdated
| if (!dev) | ||
| return -ENOMEM; | ||
|
|
||
| ret = no_os_gpio_init(&dev->gpio_a0, &init_param->gpio_a0); |
There was a problem hiding this comment.
This function doesn't exist. no_os_gpio_get() should be used.
Add support for ADG2404 analog 4:1 multiplexer. The ADG2404 switches one of four inputs to a common output, D, as determined by the 3-bit binary address line, A0, A1, and EN. Signed-off-by: Antoniu Miclaus <[email protected]>
Add README.rst for the adg2404 driver and integrate it into the sphinx build. Signed-off-by: Antoniu Miclaus <[email protected]>
amiclaus
force-pushed
the
staging/adg2404
branch
from
bfc8e3f to
2a678cc
Compare
amiclaus
commented
Sep 1, 2025
CiprianRegus
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
mux: adg2404: add initial driver support
mux: adg2404: add driver documentation
PR Type
PR Checklist