Skip to content

Conversation

@danmois
Copy link
Contributor

@danmois danmois commented Oct 30, 2025

Pull Request Description

Add ADRV904X driver and sample project

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

Add ADRV904X (Koror) driver files.

Signed-off-by: George Mois <[email protected]>
Add ADRV904X (Koror) project files.

Signed-off-by: George Mois <[email protected]>
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API should be in a separate commit and included in the ignore lists of the CI builds, and it is not subject for review in this repository. Also the driver, documentations, project should be each in its own commit. This will ease a lot the review process since there are a lot of code lines in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants