Ad7191 #598
Merged
Ad7191 #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any review comments here |
|
tfcollins
requested changes
Sep 25, 2024
Kantipudi-Supriya
force-pushed
the
ad7191
branch
3 times, most recently
from
f5204c9 to
09b3bec
Compare
1) Modified to_volts so that it gives the correct value for both unipolar and bipolar mode Signed-off-by: Kantipudi-Supriya <[email protected]>
Kantipudi-Supriya
force-pushed
the
ad7191
branch
from
09b3bec to
33aeb03
Compare
|
Hi @tfcollins any comments on this? |
|
Hi @tfcollins is it good to merge |
tfcollins
reviewed
Jul 31, 2025
|
|
||
| ret = None | ||
|
|
||
| if isinstance(val, np.int32): | ||
| ret = val * _scale | ||
| ret = (val + _offset) / 1000 * _scale |
There was a problem hiding this comment.
I'm alittle confused on the div by 1000. Standard units for IIO is mV. This will make it uV. Is that what you meant?
There was a problem hiding this comment.
Yes, we are getting in mV, This will make to get in Volts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unipolar and bipolar mode
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: