-
Notifications
You must be signed in to change notification settings - Fork 118
ad9081/_mc: fix type and first channel defaulting #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results1 676 tests ±0 442 ✅ ±0 11m 58s ⏱️ -2s For more details on these failures, see this check. Results for commit c829354. ± Comparison against base commit 6ad6c49. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
4cfb284
to
7e64edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the linter precommit tool
Some attributes are fetched from the first channel, and if multichip, first device: * ad9081: [] * ad9081_mc: {'dev1': [...], 'dev2': [...],} Due to the type change, examples/QuadMxFE_dual_example.py was broken. Use the method overwrite to fix the type and behavior. Signed-off-by: Jorge Marques <[email protected]>
Hi, I run again with the exact black version the differences from the updated #660 to the current version (broken for newer python) are pretty much the force push diff https://github.com/analogdevicesinc/pyadi-iio/compare/7e64edd25d2e38956f9d6ad254510402c2deebf7..c829354697aa6ff7507775a3850efe02ee7ffd89 |
Generated documentation for this PR is available at Link |
Description
Some attributes are fetched from the first channel, and if multichip, from the first device:
Due to the type change, examples/QuadMxFE_dual_example.py was broken.
Use the method overwrite to fix the type and behavior.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: