-
Notifications
You must be signed in to change notification settings - Fork 170
Fmcomms5 doc #2087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fmcomms5 doc #2087
Conversation
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds FMCOMMS5 support (UI, calibration, and advanced controls), refactors AD936X UI into reusable helpers, integrates MCS (multi‑chip sync), and extends docs/resources.
- Introduces FMCOMMS5 and FMCOMMS5 Advanced tools with calibration and MCS
- Refactors AD936X UI into AD936xHelper; adds DDS/CF interactions and new resources
- Updates build to link libad9361; adds emulator XML and documentation pages
Reviewed Changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 22 comments.
Show a summary per file
File | Description |
---|---|
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5tab.cpp | New FMCOMMS5 calibration tab UI and wiring |
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5calibration.cpp | Calibration logic, cross-correlation markers, switch matrix control |
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5advanced.cpp | Advanced FMCOMMS5 tool, including MCS button |
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5.cpp | Main FMCOMMS5 tool (global settings, RX/TX chains, block diagram) |
packages/ad936x/plugins/ad936x/src/ad936xplugin.cpp | Selects FMCOMMS5 vs AD936X tools based on device presence |
packages/ad936x/plugins/ad936x/src/ad936xhelper.cpp | New helper for common AD936X UI sections |
packages/ad936x/plugins/ad936x/src/ad936x/ad936xadvanced.cpp | Include path correction |
packages/ad936x/plugins/ad936x/src/ad936x/ad936x.cpp | Refactored AD936X UI using helper |
packages/ad936x/plugins/ad936x/resources/resources.qrc | Adds FMCOMMS5 board image |
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5tab.h | Header for FMCOMMS5 tab |
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5calibration.h | Calibration header and constants |
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5advanced.h | Header for advanced FMCOMMS5 tool |
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5.h | Header for FMCOMMS5 tool |
packages/ad936x/plugins/ad936x/include/ad936x/ad936xhelper.h | Header for AD936xHelper |
packages/ad936x/plugins/ad936x/include/ad936x/ad936x/ad936x.h | Updated AD936X header to use helper |
packages/ad936x/plugins/ad936x/CMakeLists.txt | Sources regrouped, libad9361 link, headers globs |
packages/ad936x/emu-xml/fmcomms5.xml | Emulator XML for FMCOMMS5 |
packages/ad936x/emu-xml/emu_setup.json | Emulator setup mapping |
packages/ad936x/CMakeLists.txt | Includes emulator XML in package |
docs/plugins/ad936x/index.rst | Adds FMCOMMS5 docs to index |
docs/plugins/ad936x/fmcomms5_advanced.rst | New FMCOMMS5 Advanced doc |
docs/plugins/ad936x/fmcomms5.rst | New FMCOMMS5 doc |
docs/plugins/ad936x/ad936x.rst | Removes placeholder text |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5calibration.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: IonutMuthi <[email protected]>
8a5cae3
to
539e1a5
Compare
Signed-off-by: IonutMuthi <[email protected]>
539e1a5
to
49fd7cb
Compare
Signed-off-by: IonutMuthi <[email protected]>
No description provided.