Skip to content

Conversation

IonutMuthi
Copy link
Contributor

No description provided.

@IonutMuthi IonutMuthi requested a review from Copilot September 22, 2025 10:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds FMCOMMS5 support (UI, calibration, and advanced controls), refactors AD936X UI into reusable helpers, integrates MCS (multi‑chip sync), and extends docs/resources.

  • Introduces FMCOMMS5 and FMCOMMS5 Advanced tools with calibration and MCS
  • Refactors AD936X UI into AD936xHelper; adds DDS/CF interactions and new resources
  • Updates build to link libad9361; adds emulator XML and documentation pages

Reviewed Changes

Copilot reviewed 24 out of 26 changed files in this pull request and generated 22 comments.

Show a summary per file
File Description
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5tab.cpp New FMCOMMS5 calibration tab UI and wiring
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5calibration.cpp Calibration logic, cross-correlation markers, switch matrix control
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5advanced.cpp Advanced FMCOMMS5 tool, including MCS button
packages/ad936x/plugins/ad936x/src/fmcomms5/fmcomms5.cpp Main FMCOMMS5 tool (global settings, RX/TX chains, block diagram)
packages/ad936x/plugins/ad936x/src/ad936xplugin.cpp Selects FMCOMMS5 vs AD936X tools based on device presence
packages/ad936x/plugins/ad936x/src/ad936xhelper.cpp New helper for common AD936X UI sections
packages/ad936x/plugins/ad936x/src/ad936x/ad936xadvanced.cpp Include path correction
packages/ad936x/plugins/ad936x/src/ad936x/ad936x.cpp Refactored AD936X UI using helper
packages/ad936x/plugins/ad936x/resources/resources.qrc Adds FMCOMMS5 board image
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5tab.h Header for FMCOMMS5 tab
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5calibration.h Calibration header and constants
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5advanced.h Header for advanced FMCOMMS5 tool
packages/ad936x/plugins/ad936x/include/ad936x/fmcomms5/fmcomms5.h Header for FMCOMMS5 tool
packages/ad936x/plugins/ad936x/include/ad936x/ad936xhelper.h Header for AD936xHelper
packages/ad936x/plugins/ad936x/include/ad936x/ad936x/ad936x.h Updated AD936X header to use helper
packages/ad936x/plugins/ad936x/CMakeLists.txt Sources regrouped, libad9361 link, headers globs
packages/ad936x/emu-xml/fmcomms5.xml Emulator XML for FMCOMMS5
packages/ad936x/emu-xml/emu_setup.json Emulator setup mapping
packages/ad936x/CMakeLists.txt Includes emulator XML in package
docs/plugins/ad936x/index.rst Adds FMCOMMS5 docs to index
docs/plugins/ad936x/fmcomms5_advanced.rst New FMCOMMS5 Advanced doc
docs/plugins/ad936x/fmcomms5.rst New FMCOMMS5 doc
docs/plugins/ad936x/ad936x.rst Removes placeholder text

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 22, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 22, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 22, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 22, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 23, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 23, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 23, 2025
@analogdevicesinc analogdevicesinc deleted a comment from Copilot AI Sep 23, 2025
@IonutMuthi IonutMuthi marked this pull request as draft September 23, 2025 08:37
Signed-off-by: IonutMuthi <[email protected]>
Signed-off-by: IonutMuthi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant