-
Notifications
You must be signed in to change notification settings - Fork 32
#166203947 Block localhosts requests to deployed environments #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
29552b6
to
e12ef87
Compare
requirements.txt
Outdated
@@ -4,7 +4,7 @@ blinker==1.4 | |||
celery==3.1.17 | |||
coverage==4.5.1 | |||
Flask==0.12.2 | |||
Flask-Cors==3.0.4 | |||
Flask-Cors==3.0.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Arusey is there any reason why this dependency was upgraded?
i figured there might be version problem
…On Fri, Jun 7, 2019 at 5:48 PM rajeman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requirements.txt
<#427 (comment)>:
> @@ -4,7 +4,7 @@ blinker==1.4
celery==3.1.17
coverage==4.5.1
Flask==0.12.2
-Flask-Cors==3.0.4
+Flask-Cors==3.0.7
@Arusey <https://github.com/Arusey> is there any reason why this
dependency was upgraded?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#427?email_source=notifications&email_token=AG3ODQVXCCRTJXPHKX57PULPZJYKTA5CNFSM4HU5EQ72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB25QW5Y#pullrequestreview-247139191>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG3ODQQ4NKEOOWJEFP5DUYDPZJYKTANCNFSM4HU5EQ7Q>
.
|
e2b2d3c
to
1251863
Compare
1251863
to
28c5fda
Compare
8ae652e
to
49d89da
Compare
Kindly include a link to the PT Board story |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @Arusey. Both the localhost, postman and insomnia requests are blocked
helpers/auth/allowed_requests.py
Outdated
|
||
|
||
def validate_origins(): | ||
"validate requests for production environments" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider placing the docstrings in """triple double quotes"""
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted
49d89da
to
3924140
Compare
e385432
to
759603d
Compare
…ents - Block requests from localhoste being made to deployment enviroments Finishes #166203947
759603d
to
06bf396
Compare
What does this PR do?
Blocks localhost requests to deployed environments
Description of Task to be completed?
When a user makes a request to deployed environments using the localhost, they should be blocked from doing so.
How should this be manually tested?
git clone https://github.com/andela/mrm_api.git
ch-block-localhost-requests-166203947
console.log('loading script')
Change the CORS in your

app.py
to be as below.Inspect the changes on your browser.
Pivotal tracker story
#166203947