Skip to content

[TASK] Fix PHP 8.5 checks without platform overrides - #10

Merged
weakbit merged 1 commit into
mainfrom
php85
Oct 27, 2026
Merged

weakbit merged 1 commit into
mainfrom
php85

Conversation

@N0S0I

@N0S0I N0S0I commented Oct 23, 2026

Copy link
Copy Markdown

Resolve compatible test dependencies without ignoring PHP platform requirements. Use the equivalent null-coalescing assignment for the cache lifetime and remove an obsolete Rector configuration entry.

Validation: the GitHub Actions branch workflow passed for b393ddeeb0fbea3a3dede3870cef32d26904a943. This PR targets main.

@N0S0I
N0S0I requested a review from weakbit October 23, 2026 06:49

N0S0I commented Oct 23, 2026

Copy link
Copy Markdown
Author

Applicable feedback carried over from Kanti's reviews of other repositories:

  • Reuse the existing GrumPHP checks instead of adding duplicate checks (source review).
  • Keep tests focused on this package; do not add tests of unrelated TYPO3 internals (source review).

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.94%. Comparing base (ac0f0a6) to head (b393dde).

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #10      +/-   ##
============================================
- Coverage     70.02%   69.94%   -0.09%     
+ Complexity      116      115       -1     
============================================
  Files             7        7              
  Lines           337      336       -1     
============================================
- Hits            236      235       -1     
  Misses          101      101              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weakbit
weakbit merged commit 7e55aac into main Oct 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants