Redshift bins in metal matrix and config builder#143
Redshift bins in metal matrix and config builder#143HiramHerrera wants to merge 3 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 38.27% 39.40% +1.12%
==========================================
Files 30 30
Lines 3888 4477 +589
Branches 720 909 +189
==========================================
+ Hits 1488 1764 +276
- Misses 2255 2531 +276
- Partials 145 182 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
julienguy
left a comment
There was a problem hiding this comment.
Looks good.
One request: please also add the reweighting of pairs according to zmin and zmax in the (now unused, but who knows) routine compute_metal_rp_dmat in metals.py.
There was a problem hiding this comment.
Pull request overview
This PR adds redshift bin filtering functionality to metal correlation matrices by introducing zmin and zmax configuration parameters. The changes enable filtering of metal matrix computations based on the redshift range of paired observations.
- Adds
zminandzmaxconfiguration parameters with defaults of 0.0 and 10.0 respectively - Implements redshift filtering in metal distortion matrix computation using the mean redshift of observation pairs
- Extends the config builder to support and propagate these new parameters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vega/metals.py | Adds zmin/zmax config reading and implements redshift-based weight filtering in compute_metal_dmat |
| vega/build_config.py | Adds zmin/zmax to config builder options and propagates them to correlation configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Hi @HiramHerrera, I see that you've added two new variables to the ini files for zmin and zmax. I think this is fine for now, but it would be great if we could just save these in the header of cf and xcf files (if they are not already there), and just read them from there. It seems to me that these are properties of the measured correlations, so treating them as variables that need to be set would just introduce potential errors. |
This PR introduces functionality to account for the redshift range in the metal matrices.
It also adds support for the corresponding configuration flags in the config builder.
Notes
These commits were made prior to the recent updates (after October 25). However, since no merge conflicts are currently detected, they should integrate smoothly.