Bump dependency versions #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm interested in learning some Rust and some voice processing, so this was a natural repo to look at!
I've had a first pass at bringing dependencies up to date. The biggest change is sample 0.10 -> dasp 0.11
A couple of things I wanted to specifically check with you:
Window<S, W>::new
now requires S of type f64, so pitch() is now limited to f64 samples. This works fine for your data, but presumably the whole point of having this generic library is that these functions can be applied to any Sample data type. https://docs.rs/dasp_signal/0.11.0/src/dasp_signal/window/mod.rs.html#79Type
, there are now twoWindow
types, one of which functions similarly toType
(they even import it as WindowType internally https://docs.rs/dasp_signal/0.11.0/src/dasp_signal/window/mod.rs.html#7), which is what I've done with HanningLag. I might be able to reinstate the previous arrangement though - would there be benefit to that? I'm guessing you had some direction you were considering exploring.I'm happy to go through and try to sort any warnings too, but thought perhaps a separate PR after this might be appropriate.
Also happy to switch the examples around to a more standard setup so they can be run as
cargo run --example example-name
if that would appeal.