Clarify critic_step_ratio parameter - no changes needed#10
Closed
Copilot wants to merge 1 commit intowasserstein-lossfrom
Closed
Clarify critic_step_ratio parameter - no changes needed#10Copilot wants to merge 1 commit intowasserstein-lossfrom
Copilot wants to merge 1 commit intowasserstein-lossfrom
Conversation
Merged
Copilot
AI
changed the title
[WIP] Fix feedback on Wasserstein loss implementation
Clarify critic_step_ratio parameter - no changes needed
Feb 3, 2026
Owner
|
So you created an empty PR just to tell me that I was correct? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reviewing the code logic, the original README description for
--critic_step_ratiowas correct. No changes are needed.Analysis
The training loop at line 295 in
fine-tune.py:With
critic_step_ratio = 5:step % 5 == 0(steps 5, 10, 15, ...)The existing description "The number of critic updates for every 1 upscaler update" accurately describes this behavior.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.