AWS provider use credentials from config #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauro13983 - thanks for raising this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current state the AwsProvider take the "AWS_ACCESS_KEY_ID" and "AWS_SECRET_ACCESS_KEY" only from os.env.
The boto3.client instance is created with the default client that take the above parameters from os.env (and internally create a static shared instance of Session)
This is very limiting when using multiple credentials on parallel processes (like web applications and each user has is own keys) or simply you don't won't to export your private keys in your env.
My proposed solution, allows to create indipendent instances of the AwsProvider (no static shared boto3.Session) and also allows to specify the "access_key_id" and "secret_access_key" parameters via the provider configuration dictionary (directly in python).