-
Notifications
You must be signed in to change notification settings - Fork 149
Add a new screen for customizing the export #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the user experience by introducing a new screen dedicated to customizing the export of generated Android bot images. Users gain more control over the final output, being able to select various aspect ratios and apply different backgrounds. This change also involves a substantial refactoring of the image rendering and export logic, along with updates to the underlying AI models.
Highlights
- New Customization Screen: A dedicated
CustomizeAndExportScreen
has been introduced, allowing users to fine-tune their generated Android bot images before export. This screen provides options for adjusting image aspect ratios and applying various backgrounds. - Enhanced Export Options: Users can now select from predefined aspect ratios (1:1, banner, wallpaper) and choose from a set of preset backgrounds (e.g., 'Lightspeed', 'I/O') to customize the visual presentation of their exported bot images.
- Refactored Image Export Pipeline: The underlying image export mechanism has been updated to use
VirtualDisplay
andGraphicsLayer
for off-screen rendering of customized Composable content into Bitmaps. This enables the dynamic application of aspect ratios and backgrounds. - Streamlined User Flow: The 'ResultsScreen' now features a 'Customize and Share' button, replacing the previous direct share/download options. This guides users to the new customization screen, centralizing all export-related functionalities.
- AI Model Updates: The application's core AI models for text and image generation have been updated to
gemini-2.5-pro
andimagen-4.0-ultra-generate-preview-06-06
respectively, as reflected in the remote configuration defaults.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new customization screen that allows users to modify their generated bot before exporting. This is a great addition to the user flow. The implementation is solid, but I've found a few areas for improvement, particularly around state management in Compose to ensure the app is robust and bug-free. I've also pointed out some minor code cleanup opportunities. Overall, fantastic work on this feature!
feature/creation/src/main/java/com/android/developers/androidify/creation/CreationScreen.kt
Outdated
Show resolved
Hide resolved
...e/results/src/main/java/com/android/developers/androidify/customize/CustomizeExportScreen.kt
Outdated
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/customize/CustomizeState.kt
Outdated
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/customize/BitmapComposable.kt
Outdated
Show resolved
Hide resolved
feature/results/src/main/java/com/android/developers/androidify/customize/BitmapComposable.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/com/android/developers/androidify/MainActivity.kt # feature/creation/src/main/java/com/android/developers/androidify/creation/CreationScreen.kt
…o work more logically and support future use cases where we may add gesture support for moving the droid around.
…to the different aspect ratio sizes.
# Conflicts: # data/src/main/java/com/android/developers/androidify/data/DataModule.kt
Add a new
CustomizeScreen
which allows users to select the ratio of the export they'd like to see, from standard 1:1 images to banner styles and wallpapers. This also adds the option to set a background on the exported image, taking the preset assets and combining the images with the generated bot.screen-20250717-154730.mp4