Skip to content

Replace deprecated icons and update ArticleScreen KDoc #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace deprecated icons and update ArticleScreen KDoc #1573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions JetNews/app/src/main/java/com/example/jetnews/ui/AppDrawer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.width
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ListAlt
import androidx.compose.material.icons.filled.Home
import androidx.compose.material.icons.filled.ListAlt
import androidx.compose.material3.DrawerState
import androidx.compose.material3.DrawerValue
import androidx.compose.material3.Icon
Expand Down Expand Up @@ -70,7 +70,7 @@ fun AppDrawer(
)
NavigationDrawerItem(
label = { Text(stringResource(id = R.string.interests_title)) },
icon = { Icon(Icons.Filled.ListAlt, null) },
icon = { Icon(Icons.AutoMirrored.Filled.ListAlt, null) },
selected = currentRoute == JetnewsDestinations.INTERESTS_ROUTE,
onClick = {
navigateToInterests()
Expand Down
6 changes: 3 additions & 3 deletions JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import androidx.compose.foundation.lazy.LazyListState
import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.ArrowBack
import androidx.compose.material.icons.automirrored.filled.ArrowBack
import androidx.compose.material3.AlertDialog
import androidx.compose.material3.BottomAppBar
import androidx.compose.material3.CenterAlignedTopAppBar
Expand Down Expand Up @@ -72,7 +72,7 @@ import kotlinx.coroutines.runBlocking
* Stateless Article Screen that displays a single post adapting the UI to different screen sizes.
*
* @param post (state) item to display
* @param showNavigationIcon (state) if the navigation icon should be shown
* @param isExpandedScreen (state) true if the window width is classified as expanded; hides navigation icon and bottom bar
* @param onBack (event) request navigate back
* @param isFavorite (state) is this item currently a favorite
* @param onToggleFavorite (event) request that this post toggle it's favorite state
Expand Down Expand Up @@ -103,7 +103,7 @@ fun ArticleScreen(
if (!isExpandedScreen) {
IconButton(onClick = onBack) {
Icon(
imageVector = Icons.Filled.ArrowBack,
imageVector = Icons.AutoMirrored.Filled.ArrowBack,
contentDescription = stringResource(R.string.cd_navigate_up),
tint = MaterialTheme.colorScheme.primary,
)
Expand Down
4 changes: 2 additions & 2 deletions JetNews/app/src/main/java/com/example/jetnews/ui/components/AppNavRail.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import android.content.res.Configuration
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.padding
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.automirrored.filled.ListAlt
import androidx.compose.material.icons.filled.Home
import androidx.compose.material.icons.filled.ListAlt
import androidx.compose.material3.Icon
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.NavigationRail
Expand Down Expand Up @@ -61,7 +61,7 @@ fun AppNavRail(currentRoute: String, navigateToHome: () -> Unit, navigateToInter
NavigationRailItem(
selected = currentRoute == JetnewsDestinations.INTERESTS_ROUTE,
onClick = navigateToInterests,
icon = { Icon(Icons.Filled.ListAlt, stringResource(R.string.interests_title)) },
icon = { Icon(Icons.AutoMirrored.Filled.ListAlt, stringResource(R.string.interests_title)) },
label = { Text(stringResource(R.string.interests_title)) },
alwaysShowLabel = false,
)
Expand Down