Skip to content

Conversation

todi1856
Copy link

kGlueCommandStrings is incorrectly initialize, thus debugging log for APP_CMD_SOFTWARE_KB_VIS_CHANGED is wrong.

APP_CMD_SOFTWARE_KB_VIS_CHANGED comes before APP_CMD_GAINED_FOCUS

Copy link

google-cla bot commented Aug 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @todi1856, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important correction in the kGlueCommandStrings array within the Android Game Development Kit (AGDK) framework. By accurately placing the APP_CMD_SOFTWARE_KB_VIS_CHANGED command, it ensures that the system's internal mapping of application commands to their string representations is correct, thereby fixing misleading debugging logs and improving the reliability of event handling.

Highlights

  • kGlueCommandStrings Initialization: Corrected the initialization of kGlueCommandStrings to properly include APP_CMD_SOFTWARE_KB_VIS_CHANGED, resolving an issue where debugging logs for this command were incorrect.
  • Debugging Accuracy: Ensured that the APP_CMD_SOFTWARE_KB_VIS_CHANGED command is correctly mapped within the kGlueCommandStrings array, which improves the accuracy of debugging output related to software keyboard visibility changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the APP_CMD_SOFTWARE_KB_VIS_CHANGED entry to the kGlueCommandStrings array. This fixes a bug where debug logs for application commands were incorrect due to a mismatch between the command enum values and the string array indices. The placement of the new string is correct, resolving the issue. The change is straightforward and effective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant