-
Notifications
You must be signed in to change notification settings - Fork 120
Unreal Sample for PGS #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added short description of the unreal project
Summary of ChangesHello @RKS13D, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive Unreal Engine sample project, 'ShooterGame,' designed to showcase the integration of Google Play Services. The sample provides practical demonstrations of Google Play Games authentication, achievements, and in-app billing, with core functionalities implemented in C++ where necessary. This addition expands the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Unreal Engine sample project demonstrating Google Play Games services integration. The overall structure is good, but there are several issues ranging from minor inconsistencies in configuration files to critical bugs in the C++ code that could lead to crashes. I've identified a critical memory issue related to dangling pointers in the UI code, unsafe map access, and some security and maintainability concerns with hardcoded values and placeholder names in configuration files. Additionally, there's a minor documentation error in the README.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The unreal/ directory contains sample demonstrating how to use Online Subsystem Google Play for implementing features like
Google Play Games Authentication
Google Play Games Achievements
Google Play Billing for in-app purchases using Google IAP