Skip to content

Commit

Permalink
version 0.4.8
Browse files Browse the repository at this point in the history
  • Loading branch information
andy-portmen committed Aug 10, 2017
1 parent 90711ea commit 457ce2c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion host.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ var files = [];
var sprocess = [];

var config = {
version: '0.4.7'
version: '0.4.8'
};
// closing node when parent process is killed
process.stdin.resume();
Expand Down
1 change: 1 addition & 0 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
cd ./app

which node 2>/dev/null
echo NodeJS status = $?

This comment has been minimized.

Copy link
@gwarser

gwarser Oct 5, 2017

This line is breaking this script.
When node is not installed, which returns 1, then, in this line, echo resets this to 0.
In following lines, even if we don't have node, we are trying to execute it.

Remove this line, or assing $? to variable.

After that, line 10 have similar problem.

This comment has been minimized.

Copy link
@andy-portmen

andy-portmen Oct 5, 2017

Author Owner

True! Thanks for the report. Please checked the latest release
https://github.com/andy-portmen/native-client/blob/master/install.sh

This comment has been minimized.

Copy link
@gwarser

gwarser Oct 5, 2017

I'm not sure, but for 32 bit systems, additional "s" in add_nodes will probably prevent installing our node executable.
Line 22: ../node/x86/node install.js --add_nodes $1

This comment has been minimized.

Copy link
@andy-portmen

andy-portmen Oct 6, 2017

Author Owner

Fixed with c5647d2. Thanks!

if [ $? -eq 0 ]; then
node -e "process.exit(Number(process.version.substr(1).split('.')[0]) > 5 ? 0 : 1)"
fi
Expand Down

0 comments on commit 457ce2c

Please sign in to comment.