Split treesitter matches at newlines instead of whitespace #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was the intention of the original change in (andymass#217): there is some mixing of terminology in the review discussion, but I believe the intention was to extract the first line in the match, as suggested in the linked discussion, and not the string up to the first whitespace.
|
Note that this is not just a nitpick about correctness, I have written matchup queries for Fennel (a lisp) that aren't highlighted correctly because of this bug (I plan to submit the queries after having used them a bit for testing). Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was the intention of the original change in (#217): there is some mixing of terminology in the review discussion, but I believe the intention was to extract the first line in the match, as suggested in the linked discussion, and not the string up to the first whitespace.