Fix mouse wheel overlay routing#209
Open
andyrewlee wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This updates mouse-wheel routing so wheel input no longer leaks through to the previously focused pane when the pointer is over a different pane that cannot consume wheel input.
It also narrows the overlay blocker so only true modal/error overlays and toast-covered coordinates block background scrolling. Prefix mode still consumes wheel input over the palette itself, but no longer blocks wheel scrolling across the rest of the UI.
Why
The bug was that wheel routing started from the focused pane and only retargeted when the hovered pane could actively consume wheel input. That allowed cases like:
A follow-up regression from the first fix made
prefixActivebehave like a full-screen wheel blocker becauseoverlayVisible()includes prefix mode. This PR fixes that by keeping prefix blocking scoped to the palette hit area.User impact
Wheel scrolling now matches pointer location more consistently:
Root cause
The original routing model fell back to the focused pane whenever the hovered pane was not a valid wheel target. That created background scrolling that did not match pointer position.
The prefix regression came from reusing
overlayVisible()for wheel blocking even though prefix mode is not a full-screen modal overlay.Validation
go test ./internal/app -run 'TestRouteMouseWheel'make lint-strict-new BASE=mainmake devcheck