Skip duplicated [rebased pr #5] #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stivens73
force-pushed
the
dont-duplicate
branch
from
f189118 to
58e3a43
Compare
Stivens73
force-pushed
the
dont-duplicate
branch
from
58e3a43 to
800183a
Compare
Author
|
Squashed all commits into one |
Owner
|
@Stivens73 Would you mind to add a test case for this? I think it's pretty important case to have |
|
Hi @angeloc , is this PR open because of absence of test case? We are also looking for the same feature, I can try to add the test case if that is the thing we are waiting for |
Owner
|
@manpreet-compro Exactly. If you can add it, it would b perfect! |
|
Hi @angeloc, I've added the test case for the "avoid duplicate" feature as per the conversation above. Pls check and review PR #24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please test and push to master.