fix(@angular-devkit/build-angular): expand jest and jest-environment-jsdom to allow version 30
#30761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
added
the
action: review
alan-agius4
changed the title
jest and jest-environment-jsdom to allow version 30jest and jest-environment-jsdom to allow version 30
alan-agius4
removed
the
action: review
…nt-jsdom` to allow version 30 This commit expands the peer deps of these dependencies to allow version 30. Closes angular#30760
dgp1130
approved these changes
Jul 22, 2025
|
|
||
| export default async function (): Promise<void> { | ||
| await applyJestBuilder(); | ||
| await silentNpm('install', '[email protected]', '[email protected]', '--save-dev'); |
There was a problem hiding this comment.
Question: Do we need to continue to support v29? Since this is still experimental, I don't think we're on the hook for backwards compatibility yet and it's probably reasonable to limit this to the latest major unless we have reason to believe that will be exceptionally difficult for users to adopt.
There was a problem hiding this comment.
So it seems that this would need further investigation to get version 30 to work. Let's have a chat about this offline to see the next steps for this builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expands the peer deps of these dependencies to allow version 30.
Closes #30760