Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

update changelog with 1.6.10 and 1.7.0-rc.0 #16528

Merged
merged 2 commits into from
Apr 19, 2018
Merged

update changelog with 1.6.10 and 1.7.0-rc.0 #16528

merged 2 commits into from
Apr 19, 2018

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Apr 11, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@Narretz
Copy link
Contributor Author

Narretz commented Apr 11, 2018 •
edited
Loading

A BC notice for #16434 (comment) is still needed has been added

Narretz
Narretz commented Apr 11, 2018
View reviewed changes
CHANGELOG.md Outdated
[#15869](https://github.com/angular/angular.js/issues/15869),
[#16512](https://github.com/angular/angular.js/issues/16512))
- **$compile:**
- throw error in $onChanges immediately
Copy link
Contributor Author

@Narretz Narretz Apr 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be backported to 1.6.x - but might technically be a BC because it removes the array and replaces it with an error

Narretz
Narretz commented Apr 11, 2018
View reviewed changes
CHANGELOG.md Outdated
[#12761](https://github.com/angular/angular.js/issues/12761),
[#16325](https://github.com/angular/angular.js/issues/16325))
- **$httpParamSerializerJQLike:**
- call functions as jQuery does
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no BC notice - backport?

Narretz
Narretz commented Apr 11, 2018
View reviewed changes
CHANGELOG.md Outdated
- **$resource:** add support for `request` and `requestError` interceptors (#15674)
([240a3d](https://github.com/angular/angular.js/commit/240a3ddbf12a9bb79754031be95dae4b6bd2dded),
[#5146](https://github.com/angular/angular.js/issues/5146))
- **$rootScope:** allow suspending and resuming watchers on scope
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was forgotten to backport! Since it's a completely new API, there should be no problem with BC

@Narretz Narretz force-pushed the docs-1-6-10-changelog branch 2 times, most recently from e44fa7f to 8b0bb3f Compare April 11, 2018 17:03
@Narretz Narretz added this to the 1.7.0 milestone Apr 11, 2018
Narretz
Narretz commented Apr 11, 2018
View reviewed changes
CHANGELOG.md
[#10076](https://github.com/angular/angular.js/issues/10076),
[#16347](https://github.com/angular/angular.js/issues/16347))
- **$httpParamSerializerJQLike:**
- call functions as jQuery does
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also no backported - any ideas why?

Copy link
Contributor Author

@Narretz Narretz Apr 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's leave it in 1.7, because there's another changeto the serializer that is only in 1.7

mgol
mgol reviewed Apr 11, 2018
View reviewed changes
CHANGELOG.md Outdated
[#5146](https://github.com/angular/angular.js/issues/5146))
- **$rootScope:** allow suspending and resuming watchers on scope
([41d5c9](https://github.com/angular/angular.js/commit/41d5c90f170cc054b0f8f88220c22ef1ef6cc0a6),
[#5301](https://github.com/angular/angular.js/issues/5301))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the PR link: #16308

@Narretz Narretz force-pushed the docs-1-6-10-changelog branch 3 times, most recently from 003b31e to 621cc85 Compare April 13, 2018 09:27
@Narretz
Copy link
Contributor Author

Narretz commented Apr 13, 2018

I've added the migration docs.

Note that because our docs generation does not detect duplicate headlines, the table of contents for the migration guide doesn't completely work, e.g. $compile is generated twice, so the link the contents always lead to the first entry (in 1.6 to 1.7)

@gkalpak
Copy link
Member

gkalpak commented Apr 13, 2018

LGTM from a quick look.
Minor nit: "En--ing" things like service/directive names and AngularJS-specific props (e.g. $resource, $submitted, etc) would be more consistent with the rest of the docs/changelog.

By "en--ing", I mean wrapping in backticks :grin:

@Narretz Narretz force-pushed the docs-1-6-10-changelog branch from 621cc85 to 22f6e9b Compare April 19, 2018 08:04
@Narretz Narretz force-pushed the docs-1-6-10-changelog branch from 22f6e9b to 19f6949 Compare April 19, 2018 08:06
@Narretz Narretz merged commit 841feb0 into angular:master Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgol mgol mgol left review comments

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Narretz @gkalpak @mgol @googlebot