Skip to content

docs(material/select): fix select within dialog example not selecting option #20891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

docs(material/select): fix select within dialog example not selecting option #20891

merged 1 commit into from
Oct 28, 2020

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Oct 26, 2020

<mat-option> within the select was missing [value]

Fixes: #20840

@annieyw annieyw requested review from jelbourn and mmalerba October 26, 2020 23:09
@annieyw annieyw requested a review from crisbeto as a code owner October 26, 2020 23:09
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2020
@annieyw annieyw added docs This issue is related to documentation merge safe labels Oct 26, 2020
crisbeto
crisbeto approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one nit.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 27, 2020
@annieyw annieyw added the P4 A relatively minor issue that is not relevant to core functions label Oct 27, 2020
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Oct 27, 2020
@wagnermaciel
Copy link
Contributor

@annieyw Seems like this change has conflicts with 10.2.x. Would it be ok to change this to target: minor?

@annieyw
Copy link
Contributor Author

annieyw commented Oct 28, 2020

@wagnermaciel I think it should be fine, this is just a fix to the dev app

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 28, 2020
@wagnermaciel wagnermaciel merged commit a501f31 into angular:master Oct 28, 2020
@rameshworsht
Copy link
Contributor

@annieyw The issue that I have raised on #20840 is not an example issue. I am okay with it being closed cause @jelbourn has created a new issue #20900 for it.

@annieyw annieyw deleted the select-dev-app branch October 29, 2020 16:43
@annieyw
Copy link
Contributor Author

annieyw commented Oct 29, 2020

@rameshworsht Sorry for the confusion, seems like the underlying issue with the dev app masked the real issue you were trying to report. Thanks for pointing it out.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P4 A relatively minor issue that is not relevant to core functions target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(material/select): select with dialog example in dev app not selecting options
6 participants
@annieyw @wagnermaciel @rameshworsht @crisbeto @jelbourn @mmalerba