fix(material/tabs): glitchy animation in rtl with lazy-loaded content #31535
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
ok7sai
and removed request for
a team
When the tabs have lazy-loaded content, their height can be zero to begin with. This appeared to hit a Chrome bug where animating the `transform` on a zero-height element in RTL was interrupting the animation. These changes fix the bug by setting a minimum height. Fixes angular#31503.
crisbeto
force-pushed
the
31503/tabs-rtl-animation
branch
from
d455d7b to
02a5da7
Compare
andrewseguin
approved these changes
Jul 15, 2025
crisbeto
added a commit
that referenced
this pull request
Jul 16, 2025
…#31535) When the tabs have lazy-loaded content, their height can be zero to begin with. This appeared to hit a Chrome bug where animating the `transform` on a zero-height element in RTL was interrupting the animation. These changes fix the bug by setting a minimum height. Fixes #31503. (cherry picked from commit 892c281)
|
The changes were merged into the following branches: main, 20.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tabs have lazy-loaded content, their height can be zero to begin with. This appeared to hit a Chrome bug where animating the
transformon a zero-height element in RTL was interrupting the animation.These changes fix the bug by setting a minimum height.
Fixes #31503.