Skip to content

[20.2.x] build: enable strict deps enforcement for ts_project #31781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 20.2.x
Choose a base branch
from
+162 −73
Open

[20.2.x] build: enable strict deps enforcement for ts_project #31781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ git_override(
bazel_dep(name = "devinfra")
git_override(
module_name = "devinfra",
commit = "f27fc330e9ebdd07ca713aff3c25a553cb824e37",
commit = "b281f43529c2e03f5c286b919efcb369b47a4aa5",
remote = "https://github.com/angular/dev-infra.git",
)

Expand Down
91 changes: 49 additions & 42 deletions MODULE.bazel.lock
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/cdk-experimental/accordion/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ng_project(
"public-api.ts",
],
deps = [
"//:node_modules/@angular/core",
"//src/cdk-experimental/deferred-content",
"//src/cdk-experimental/ui-patterns",
"//src/cdk/a11y",
Expand Down
2 changes: 1 addition & 1 deletion src/cdk-experimental/accordion/accordion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
AccordionGroupPattern,
AccordionPanelPattern,
AccordionTriggerPattern,
} from '../ui-patterns/';
} from '../ui-patterns';

/**
* Represents the content panel of an accordion item. It is controlled by an
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/tabs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ng_project(
"tabs.ts",
],
deps = [
"//:node_modules/@angular/core",
"//src/cdk-experimental/deferred-content",
"//src/cdk-experimental/ui-patterns",
"//src/cdk/a11y",
Expand Down
4 changes: 3 additions & 1 deletion src/cdk-experimental/tree/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ ng_project(
"tree.ts",
],
deps = [
"//:node_modules/@angular/core",
"//src/cdk-experimental/deferred-content",
"//src/cdk-experimental/ui-patterns",
"//src/cdk-experimental/ui-patterns/tree",
"//src/cdk/a11y",
"//src/cdk/bidi",
],
Expand All @@ -25,6 +26,7 @@ ts_project(
],
deps = [
":tree",
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//src/cdk/testing/private",
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/accordion/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ ts_project(
deps = [
":accordion",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/signal-like",
"//src/cdk/keycodes",
"//src/cdk/testing/private",
],
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/behaviors/grid-navigation/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ ts_project(
deps = [
":grid-navigation",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/grid-focus",
],
)

Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/behaviors/list-selection/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ts_project(
deps = [
":list-selection",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/list-focus",
"//src/cdk-experimental/ui-patterns/behaviors/list-focus:unit_test_sources",
],
)
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/behaviors/list-typeahead/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ts_project(
deps = [
":list-typeahead",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/list-focus",
"//src/cdk-experimental/ui-patterns/behaviors/list-focus:unit_test_sources",
],
)
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/tabs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ ts_project(
deps = [
":tabs",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/signal-like",
"//src/cdk/keycodes",
"//src/cdk/testing/private",
],
Expand Down
2 changes: 2 additions & 0 deletions src/cdk-experimental/ui-patterns/toolbar/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ ts_project(
deps = [
":toolbar",
"//:node_modules/@angular/core",
"//src/cdk-experimental/radio-group",
"//src/cdk-experimental/ui-patterns/radio-group",
"//src/cdk/keycodes",
"//src/cdk/testing/private",
],
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/ui-patterns/tree/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ts_project(
deps = [
":tree",
"//:node_modules/@angular/core",
"//src/cdk-experimental/ui-patterns/behaviors/signal-like",
"//src/cdk/keycodes",
"//src/cdk/testing/private",
],
Expand Down
2 changes: 2 additions & 0 deletions src/cdk/listbox/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ ng_project(
"//:node_modules/rxjs",
"//src/cdk/a11y",
"//src/cdk/bidi",
"//src/cdk/coercion",
"//src/cdk/collections",
"//src/cdk/keycodes",
"//src/cdk/platform",
],
)

Expand Down
2 changes: 2 additions & 0 deletions src/cdk/menu/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ ng_project(
"//src/cdk/collections",
"//src/cdk/keycodes",
"//src/cdk/overlay",
"//src/cdk/platform",
"//src/cdk/portal",
],
)

Expand Down
13 changes: 10 additions & 3 deletions src/cdk/schematics/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@ rules_js_tsconfig(
src = "tsconfig.json",
)

rules_js_tsconfig(
name = "tsconfig_test",
src = "tsconfig-test.json",
deps = [
":tsconfig",
],
)

ts_project(
name = "schematics",
srcs = glob(
Expand All @@ -39,7 +47,7 @@ ts_project(
"testing/**/*.ts",
],
),
tsconfig = "tsconfig.json",
tsconfig = ":tsconfig",
deps = [
"//:node_modules/@angular-devkit/core",
"//:node_modules/@angular-devkit/schematics",
Expand Down Expand Up @@ -77,8 +85,7 @@ ts_project(
"**/files/**/*.spec.ts",
],
),
extends = "tsconfig.json",
tsconfig = "tsconfig-test.json",
tsconfig = "tsconfig_test",
deps = [
":schematics",
"//:node_modules/@angular-devkit/schematics",
Expand Down
12 changes: 10 additions & 2 deletions src/cdk/schematics/testing/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,24 @@
load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
load("//tools:defaults.bzl", "ts_project")

package(default_visibility = ["//visibility:public"])

ts_config(
name = "tsconfig",
src = "tsconfig.json",
deps = [
"//src/cdk/schematics:tsconfig",
],
)

ts_project(
name = "testing",
testonly = True,
srcs = glob(["**/*.ts"]),
# Needed to ensure these files are picked up as CommonJS, as otherwise
# the higher-level `package.json` from `src/package.json` is `type: module`.
data = ["//src/cdk/schematics:package_json"],
extends = "//src/cdk/schematics:tsconfig",
tsconfig = "tsconfig.json",
tsconfig = ":tsconfig",
deps = [
"//:node_modules/@angular-devkit/core",
"//:node_modules/@angular-devkit/schematics",
Expand Down
12 changes: 10 additions & 2 deletions src/cdk/schematics/update-tool/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
load("@aspect_rules_ts//ts:defs.bzl", "ts_config")
load("//tools:defaults.bzl", "ts_project")

package(default_visibility = ["//visibility:public"])

ts_config(
name = "tsconfig",
src = "tsconfig.json",
deps = [
"//src/cdk/schematics:tsconfig",
],
)

ts_project(
name = "update-tool",
srcs = glob(["**/*.ts"]),
extends = "//src/cdk/schematics:tsconfig",
tsconfig = ":tsconfig.json",
tsconfig = ":tsconfig",
deps = [
"//:node_modules/@types/node",
"//:node_modules/typescript",
Expand Down
1 change: 1 addition & 0 deletions src/cdk/table/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ ts_project(
),
deps = [
":table",
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//:node_modules/rxjs",
Expand Down
1 change: 1 addition & 0 deletions src/cdk/testing/private/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ts_project(
"//:node_modules/@angular/core",
"//:node_modules/@types/jasmine",
"//:node_modules/axe-core",
"//:node_modules/rxjs",
"//src/cdk/bidi",
"//src/cdk/testing/testbed",
],
Expand Down
1 change: 1 addition & 0 deletions src/cdk/tree/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ ts_project(
),
deps = [
":tree",
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/rxjs",
"//src/cdk/a11y",
Expand Down
2 changes: 2 additions & 0 deletions src/components-examples/cdk-experimental/accordion/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ ng_project(
"**/*.css",
]),
deps = [
"//:node_modules/@angular/core",
"//:node_modules/@angular/forms",
"//src/cdk-experimental/accordion",
"//src/material/checkbox",
"//src/material/form-field",
Expand Down
2 changes: 2 additions & 0 deletions src/components-examples/cdk-experimental/tabs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ ng_project(
"**/*.css",
]),
deps = [
"//:node_modules/@angular/core",
"//:node_modules/@angular/forms",
"//src/cdk-experimental/tabs",
"//src/material/checkbox",
"//src/material/form-field",
Expand Down
1 change: 1 addition & 0 deletions src/components-examples/cdk-experimental/tree/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ng_project(
"**/*.css",
]),
deps = [
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/@angular/forms",
"//src/cdk-experimental/tree",
Expand Down
5 changes: 4 additions & 1 deletion src/dev-app/cdk-experimental-accordion/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ ng_project(
"cdk-accordion-demo.html",
"cdk-accordion-demo.css",
],
deps = ["//src/components-examples/cdk-experimental/accordion"],
deps = [
"//:node_modules/@angular/core",
"//src/components-examples/cdk-experimental/accordion",
],
)
5 changes: 4 additions & 1 deletion src/dev-app/cdk-experimental-tabs/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ ng_project(
"cdk-tabs-demo.html",
"cdk-tabs-demo.css",
],
deps = ["//src/components-examples/cdk-experimental/tabs"],
deps = [
"//:node_modules/@angular/core",
"//src/components-examples/cdk-experimental/tabs",
],
)
5 changes: 4 additions & 1 deletion src/dev-app/cdk-experimental-tree/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@ ng_project(
name = "cdk-experimental-tree",
srcs = glob(["**/*.ts"]),
assets = ["cdk-tree-demo.html"],
deps = ["//src/components-examples/cdk-experimental/tree"],
deps = [
"//:node_modules/@angular/core",
"//src/components-examples/cdk-experimental/tree",
],
)
1 change: 1 addition & 0 deletions src/dev-app/dev-app/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ng_project(
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/@angular/router",
"//:node_modules/rxjs",
"//src/cdk/bidi",
"//src/cdk/overlay",
"//src/material/button",
Expand Down
1 change: 1 addition & 0 deletions src/material/autocomplete/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ ts_project(
),
deps = [
":autocomplete",
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//:node_modules/@angular/forms",
"//:node_modules/@angular/platform-browser",
Expand Down
1 change: 1 addition & 0 deletions src/material/bottom-sheet/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ ts_project(
"//src/cdk/platform",
"//src/cdk/scrolling",
"//src/cdk/testing/private",
"//src/material/core",
],
)

Expand Down
4 changes: 4 additions & 0 deletions src/material/core/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ ng_project(
],
deps = [
":version",
"//:node_modules/@angular/core",
"//:node_modules/rxjs",
"//src:dev_mode_types",
"//src/material/core:ripple",
Expand Down Expand Up @@ -112,11 +113,13 @@ ts_project(
),
deps = [
":core",
":ripple",
"//:node_modules/@angular/core",
"//:node_modules/@angular/platform-browser",
"//src/cdk/keycodes",
"//src/cdk/platform",
"//src/cdk/testing/private",
"//src/material/core/animation",
"//src/material/testing",
],
)
Expand Down Expand Up @@ -220,6 +223,7 @@ ng_project(
":ripple_structure",
],
deps = [
"//:node_modules/@angular/core",
"//src/cdk/a11y",
"//src/cdk/coercion",
"//src/cdk/platform",
Expand Down
1 change: 1 addition & 0 deletions src/material/core/common-behaviors/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ ng_project(
"palette.ts",
],
deps = [
"//:node_modules/@angular/core",
"//:node_modules/@angular/forms",
"//:node_modules/rxjs",
"//src/cdk/a11y",
Expand Down
1 change: 1 addition & 0 deletions src/material/core/option/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ ng_project(
":option_css",
],
deps = [
"//:node_modules/@angular/core",
"//:node_modules/rxjs",
"//src/cdk/a11y",
"//src/cdk/keycodes",
Expand Down
1 change: 1 addition & 0 deletions src/material/core/private/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ng_project(
],
deps = [
"//:node_modules/@angular/common",
"//:node_modules/@angular/core",
"//src/cdk/platform",
"//src/cdk/private",
"//src/material/core:ripple",
Expand Down
1 change: 1 addition & 0 deletions src/material/core/testing/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ts_project(
"//src/cdk/testing",
"//src/cdk/testing/testbed",
"//src/material/core",
"//src/material/core/option",
],
)

Expand Down
1 change: 1 addition & 0 deletions src/material/datepicker/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ ts_project(
"//src/cdk/platform",
"//src/cdk/scrolling",
"//src/cdk/testing/private",
"//src/material/button",
"//src/material/core",
"//src/material/form-field",
"//src/material/input",
Expand Down
2 changes: 2 additions & 0 deletions src/material/datepicker/testing/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ ts_project(
"//src/cdk/testing/testbed",
"//src/material/core",
"//src/material/datepicker",
"//src/material/form-field",
"//src/material/input",
],
)

Expand Down
Loading
Loading