Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 4, 2017

Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like #8653 without having to overwrite the entire position strategy.

… init

Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like angular#8653 without having to overwrite the entire position strategy.
@crisbeto crisbeto requested a review from jelbourn as a code owner December 4, 2017 19:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Dec 5, 2017
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release and removed target: minor This PR is targeted for the next minor release labels Dec 6, 2017
@andrewseguin andrewseguin merged commit b7071ba into angular:master Dec 13, 2017
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Dec 19, 2017
… init (angular#8800)

Backports the ability to update a connected overlay's positioning from the new flexible connected position strategy. This helps facilitate cases like angular#8653 without having to overwrite the entire position strategy.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants