fix(language-server): Do best-effort to initialize composite project … #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when HTML is opened first An upstream TypeScript performance-motivated change ( microsoft/TypeScript@02b07a1) made it so composite projects are not opened unless the opened file is in the includes/files list of the `tsconfig`. This means that external HTML files do not trigger project loading when they are the first and only file opened. As a best-effort, we attempt to open a TS file with the same name, which will most often be the file for the component of the external template. This is not guaranteed to be the case, so the only way to guarantee this works correctly would be for developers to add the `**/*.html` files to the `includes` list of their `tsconfig[.lib].json`. resolves angular#2149
2 tasks
jarpoole
approved these changes
Mar 29, 2025
There was a problem hiding this comment.
At least for my team, this fix would be 100% successful across our entire monorepo!
See #2149 (comment)
clydin
approved these changes
Apr 16, 2025
atscott
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when HTML is opened first
An upstream TypeScript performance-motivated change ( microsoft/TypeScript@02b07a1) made it so composite projects are not opened unless the opened file is in the includes/files list of the
tsconfig. This means that external HTML files do not trigger project loading when they are the first and only file opened.As a best-effort, we attempt to open a TS file with the same name, which will most often be the file for the component of the external template. This is not guaranteed to be the case, so the only way to guarantee this works correctly would be for developers to add the
**/*.htmlfiles to theincludeslist of theirtsconfig[.lib].json.resolves #2149