Replaced 'L' with 'l' for liter abbreviations#1503
Closed
Jagailo wants to merge 6 commits intoangularsen:release/v6from
Jagailo:consistency-in-liter-abbreviations
Closed
Replaced 'L' with 'l' for liter abbreviations#1503Jagailo wants to merge 6 commits intoangularsen:release/v6from Jagailo:consistency-in-liter-abbreviations
Jagailo wants to merge 6 commits intoangularsen:release/v6from
Jagailo:consistency-in-liter-abbreviations
Conversation
Fixes #1423 `UnitParser.Parse<LengthUnit>("MM")` fails due to matching both `Megameter` and `Millimeter` in case-insensitive matching, but matches neither of them in the case-sensitive fallback. It was confusing to get `UnitsNotFoundException` in this case, since case-insensitive usually works for most units. ### Changes - Handle this case and throw `AmbiguousUnitParseException` instead of `UnitNotFoundException` - Describe the case-insensitive units that matched - Fix existing test `Parse_WithMultipleCaseInsensitiveMatchesButNoExactMatches_ThrowsUnitNotFoundException` - Skip retrying with fallback culture if no specific `formatProvider` was given
CI build failed due net7.0 no longer being available.
Fixes CI build due to net7 no longer being available. New convention for target frameworks: - netstandard2.0 - latest LTS version (net8.0) - any newer STS versions (net9.0)
**AreaMomentOfInertia:** > Use superscript (cm², m³) instead of cm^2, m^3 **MolarEntropy:** > Use · for products (N·m instead of Nm, N*m or N.m) **SpecificEntropy:** > Use · for products (N·m instead of Nm, N*m or N.m) Using parentheses for mathematically correct display; using the correct symbol for degrees Celsius **SpecificFuelConsumption:** It looks like some unusual multiplication sign was used **WarpingMomentOfInertia:** > Use superscript (cm², m³) instead of cm^2, m^3 --- For ^4 and ^6 UnitParser.NormalizeUnitString() will handle this situation --------- Co-authored-by: Alexey Yagelo <Alexey.Yagelo@medi.report> Co-authored-by: Andreas Gullberg Larsen <andreas.larsen84@gmail.com>
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Owner
|
Sorry for no response on this one, I'm positive to make this change, but please retarget the PR for |
Contributor
Author
|
Moved to another branch |
Owner
|
There are some merge conflicts to handle after changing target branch. Depending on your comfort level with Git it may be easier to just start over and manually copy the changes and re-generate. I believe most of your changes should still work for release/v6, and the conflicts are mostly related to the generated code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was reading the article on adding new units I noticed this line:
I ran a script and about half of the "liters" use
Land the other half usel. Even within the same quantity, different liters are used:In this pull request I replaced
Lwithlaccording to abbreviation naming conventions. Open to any suggestions on how else this could be handled.