Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion UnitsNet/CustomCode/UnitAbbreviationsCache.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public sealed class UnitAbbreviationsCache
/// information about quantities and their associated units. It is used internally to map units
/// to their abbreviations and vice versa.
/// </remarks>
internal QuantityInfoLookup Quantities { get; }
public QuantityInfoLookup Quantities { get; }

/// <summary>
/// Culture name to abbreviations. To add a custom default abbreviation, add to the beginning of the list.
Expand Down
2 changes: 1 addition & 1 deletion UnitsNet/CustomCode/UnitParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public UnitParser(UnitAbbreviationsCache unitAbbreviationsCache)
/// This property provides access to the <see cref="QuantityInfoLookup" /> that contains
/// information about all quantities and their associated units.
/// </remarks>
internal QuantityInfoLookup Quantities
public QuantityInfoLookup Quantities
{
get => Abbreviations.Quantities;
}
Expand Down
10 changes: 1 addition & 9 deletions UnitsNet/CustomCode/UnitsNetSetup.cs
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
// Licensed under MIT No Attribution, see LICENSE file at the root.
// Copyright 2013 Andreas Gullberg Larsen (andreas.larsen84@gmail.com). Maintained at https://github.com/angularsen/UnitsNet.

using System;
using System.Collections.Generic;
using System.Linq;
using UnitsNet.Units;

namespace UnitsNet;

/// <summary>
Expand Down Expand Up @@ -88,8 +83,5 @@ public UnitsNetSetup(IEnumerable<QuantityInfo> quantityInfos, UnitConverter unit
/// <summary>
/// The quantities and units that are loaded.
/// </summary>
/// <remarks>
/// Access type is <c>internal</c> until this class is matured and ready for external use.
/// </remarks>
internal QuantityInfoLookup QuantityInfoLookup { get; }
Comment on lines -91 to -94

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't got any burning need to rename this, but it would perhaps make it more consistent if we used Quantities as the property name.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes to consistency please, I renamed it

public QuantityInfoLookup QuantityInfoLookup { get; }
}
2 changes: 1 addition & 1 deletion UnitsNet/QuantityInfoLookup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ namespace UnitsNet;
/// <remarks>
/// Access type is <c>internal</c> until this class is matured and ready for external use.
/// </remarks>
internal class QuantityInfoLookup
public class QuantityInfoLookup
{
private readonly QuantityInfo[] _quantities;
private readonly Lazy<QuantityByNameLookupDictionary> _quantitiesByName;
Expand Down