Improve Derivatiles: bug fixes, new gameplay features, and code cleanup#2
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
Improve Derivatiles: bug fixes, new gameplay features, and code cleanup#2devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Bug fixes: - Fix String comparison using == instead of .equals() in BoardState - Move correctDerivatives init from constructor (where numRows=0) to startGame - Fix multi-digit coefficient parsing in Differentiate (e.g. x^10 -> 10x^9) - Trim whitespace from function strings to prevent matching issues - Remove unused import (javax.swing.tree.TreeModel) New features: - Visual feedback: green/red text on correct/incorrect answers - Game-over screen with final score, accuracy stats, and letter grade - Streak bonus system: consecutive correct answers earn extra points - Countdown timer (15s per question, -2 pts on timeout) - Wrong answer penalty (-1 pt) - Instructions/help text on the welcome screen - Play Again button on game-over screen Improvements: - Slider minimum changed from 0 to 1 (0 was invalid) - Expanded function bank from 28 to 50 questions - Replaced magic key code numbers with KeyEvent constants - Removed debug System.out.println statements - Fixed duplicate imports in Game.java - Renamed unclear variable (uselessAndOnlyForConstAtBeginningCase -> skipNextSign) - Quit button text changed from 'Get a life' to 'Quit' Co-Authored-By: Anish Lakkapragada <[email protected]>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…ositioning The JFrame's default BorderLayout was overriding setBounds() calls, causing labels, buttons, and instructions to not render. Added getContentPane().setLayout(null) to match the absolute positioning pattern used throughout the codebase. Co-Authored-By: Anish Lakkapragada <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes, new gameplay features, and code quality improvements for the Derivatiles calculus practice game.
Bug fixes:
==vs.equals()for String comparison inBoardState.getGrid()(was always false)correctDerivativesarray init from constructor (wherenumRowsis 0) tostartGame()Differentiate—x^10 → 10x^9now works instead of silently breaking on multi-digit coefficientsgetContentPane().setLayout(null)so thatsetBounds()positioning works correctly (defaultBorderLayoutwas silently overriding all component positions, causing labels/buttons to not render)New features:
3 + streakptsCode cleanup:
System.out.printlncallsuselessAndOnlyForConstAtBeginningCase→skipNextSignKeyEvent.VK_*constantsReview & Testing Checklist for Human
evaluatePointsstrips HTML tags from tile labels via regex (<[^>]*>) before comparing to the plain-text correct derivative.formatSubscript(label, true)wraps exponents in<html><sup>...</sup></html>, and functions without exponents return raw text (no tags). Verify by playing a round — select a correct answer and confirm points are actually awarded. If the regex misses something or the formatting produces extra whitespace, correct answers will always register as wrong.Differentiatehandles derivatives like10x^9, but thepreCoefficientparsing still reads everything before^minus 1 char (substring(0, indexOf("^") - 1)). Verify that functions like3x^7(which should produce21x^6) and higher-power terms compute correctly — especially multi-term functions where the coefficient and derivative coefficient are both multi-digit."Calibri", which is not installed on most Linux systems. Java falls back to a default font, but verify text renders legibly and nothing is clipped due to different font metrics.setBounds()withnulllayout. Run the game and verify nothing overlaps — especially the feedback label, streak label, timer label, and the instructions text on the welcome screen.Suggested test plan: Run the game locally (
javac src/*.java && java src.Game), play through a few rounds on derivative orders 1–3, deliberately get some right and wrong, let the timer expire once, and play until the game-over screen appears. Verify scores, streaks, and accuracy stats look correct.Notes
questionsAnsweredincrements once per row evaluated (each derivative order), not once per function — a 3rd-order game answering 10 functions shows ~30 "questions" on the game-over screenLink to Devin session: https://app.devin.ai/sessions/15e67a49f8b940178a2006ec7ae616ce
Requested by: @anish-lakkapragada