Skip to content

Conversation

rovertrack
Copy link

Purpose / Description

change backups folder from "backup" to "backups"

Fixes

Fixes #19138

#19138

Copy link

welcome bot commented Aug 29, 2025

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct but there's the discussion of the backup files we leave behind. #15034 would be the proper fix.

if (!moveDatabaseToBrokenDirectory(colFile, false, time)) {
Timber.e("repairCollection - could not move corrupt file to broken directory")
return false
Timber.e("repairCollection - could not move corrupt file to broken directory")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this.

@lukstbit lukstbit added the Needs reviewer reply Waiting for a reply from another reviewer label Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs reviewer reply Waiting for a reply from another reviewer New contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make backup directory consistent with Anki desktop
2 participants